From eb19a7bd0bc5e57f3ffd6fca9a43a8ae71c36833 Mon Sep 17 00:00:00 2001 From: broken Date: Thu, 20 Jan 2022 14:17:33 +0100 Subject: [PATCH 1/4] fixed memory leaks --- src/backend/readmng.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/backend/readmng.c b/src/backend/readmng.c index b225e30..7ab3f88 100644 --- a/src/backend/readmng.c +++ b/src/backend/readmng.c @@ -409,6 +409,7 @@ cleanup_mg_backend_readmng_retrieve_manga_details: if (movie_detail) { g_free (movie_detail); } + xmlFreeDoc(html_document); } static GListStore * @@ -453,6 +454,9 @@ cleanup_mg_backend_readmng_recover_chapter_list: xmlXPathFreeObject(xpath_result); } if (uls) { + for (size_t i = 0; i < ul_len; i++) { + xmlFreeNode(uls[i]); + } g_free (uls); } return return_value; @@ -588,6 +592,7 @@ mg_backend_readmng_parse_main_page (MgBackendReadmng *self, const xmlDocPtr html xmlFreeNode (current_li); li[i] = NULL; } + xmlFreeNode(slides); g_free (li); return mangas; } @@ -643,6 +648,11 @@ cleanup_mg_backend_readmng_retrieve_slides: xmlXPathFreeObject(xpath_result); } if (nodes) { + for (size_t i = 1; i < matching_classes_len; i++) + { + xmlFreeNode(nodes[i]); + } + g_free (nodes); } return slides; From a49e12154f77c50b9ac5f2fae95cb7b572313411 Mon Sep 17 00:00:00 2001 From: broken Date: Thu, 20 Jan 2022 14:22:47 +0100 Subject: [PATCH 2/4] Added valgrind supression list --- openmg.supp | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 openmg.supp diff --git a/openmg.supp b/openmg.supp new file mode 100644 index 0000000..97e8055 --- /dev/null +++ b/openmg.supp @@ -0,0 +1,36 @@ +# +# Valgrind suppression file for mangareader. +# Warning: This file is very generic, so a real memory leak might be suppressed. +# Also, some false positives are still captured +# +# Format specification: +# http://valgrind.org/docs/manual/manual-core.html#manual-core.suppress +# +{ + gtk4 + Memcheck:Leak + ... + obj:/usr/lib/x86_64-linux-gnu/libgtk-4.so.1.600.0 + ... +} +{ + glib + Memcheck:Leak + ... + obj:/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7100.0 + ... +} +{ + fontconfig + Memcheck:Leak + ... + obj:/usr/lib/x86_64-linux-gnu/libfontconfig.so.1.12.0 + ... +} +{ + gallium + Memcheck:Leak + ... + obj:/usr/lib/x86_64-linux-gnu/GL/default/lib/dri/libgallium_dri.so + ... +} From 14c671c78b63f102558edc50632c6c908d5c7c80 Mon Sep 17 00:00:00 2001 From: endes Date: Thu, 20 Jan 2022 17:42:40 +0100 Subject: [PATCH 3/4] updated AUTHORS.md --- AUTHORS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.md b/AUTHORS.md index bb44edc..7b70e33 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -1,2 +1,3 @@ Sergiotarxz sergiotarxz@posteo.net Project leader and developer [Gitea](https://gitea.sergiotarxz.freemyip.com/sergiotarxz) Germe.db FOSSgerme.deb@tuta.io Author of the icon openmg.svg. [sr.ht](https://sr.ht/~germe-fur/) +Endes endes@disroot.org Some small fixes [Github](https://github.com/endes0) From 44689c95616a2ccbcf72d5483874bbc32bcbd19c Mon Sep 17 00:00:00 2001 From: endes Date: Thu, 20 Jan 2022 17:45:50 +0100 Subject: [PATCH 4/4] corrected 'AUTHORS.md' --- AUTHORS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS.md b/AUTHORS.md index 7b70e33..5efa8be 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -1,3 +1,3 @@ Sergiotarxz sergiotarxz@posteo.net Project leader and developer [Gitea](https://gitea.sergiotarxz.freemyip.com/sergiotarxz) Germe.db FOSSgerme.deb@tuta.io Author of the icon openmg.svg. [sr.ht](https://sr.ht/~germe-fur/) -Endes endes@disroot.org Some small fixes [Github](https://github.com/endes0) +Endes endes@disroot.org Developer [Github](https://github.com/endes0)