The theme connects to https://fonts.googleapis.com/. #3
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
sergiotarxz commented Jul 17, 2020
When I readed the Bludit webpage it ensures it doesn't load external resources so it may confuse some admins. I can do a pull request to solve this since I have done it before.
@clickwork-git clickwork-git closed this Jul 17, 2020
@clickwork-git clickwork-git reopened this Jul 17, 2020
@sergiotarxz
Contributor Author
sergiotarxz commented Jul 17, 2020 •
I don't know now if would be worth to pull request such change because this appears not to be the official repository of the theme.
If there is not currently a maintainer I am open to maintain it if someone reviews my changes so I don't do nothing silly without knowing.
(Finally it appears pull request are being accepted here so there is no problem.)
sergiotarxz added a commit to sergiotarxz/micro that referenced this issue Jul 22, 2020
@sergiotarxz
Avoiding external connections to Google fonts.
856b344
@sergiotarxz sergiotarxz mentioned this issue Jul 22, 2020
Avoiding external connections to Google fonts.
Closed
sergiotarxz added a commit to sergiotarxz/micro that referenced this issue Jul 22, 2020
@sergiotarxz
Ensuring fonts are loaded before the rest of css just in case.
3b813f0
@sergiotarxz
Contributor Author
sergiotarxz commented Jul 22, 2020
This is being solved at [github merge which doesn't matter anyway].
@sergiotarxz
Contributor Author
sergiotarxz commented Jul 22, 2020
For what I have read about cross browser font support this can get very hard with older browsers while Google fonts work at is it.
I don't think we should give too much effort into supporting IE since it is deprecated but some android and ios devices don't support woff2, I am thinking in support ttf, svg and woff2 and ignore browsers not supporting that formats.
If that font can not be loaded maybe we can choose some which also looks good with micro and comes with browsers as a fallback.
I don't know, this may require thinking about it again, but I find the need to use external resources disgusting at least, more yet with Google's story about getting into the users privacy.
Done.