2019-10-17 18:36:52 +02:00
|
|
|
defmodule Pleroma.Web.ActivityPub.ObjectValidatorTest do
|
|
|
|
use Pleroma.DataCase
|
|
|
|
|
2020-04-28 16:45:28 +02:00
|
|
|
alias Pleroma.Object
|
2020-04-20 12:29:19 +02:00
|
|
|
alias Pleroma.Web.ActivityPub.Builder
|
2019-10-17 18:36:52 +02:00
|
|
|
alias Pleroma.Web.ActivityPub.ObjectValidator
|
|
|
|
alias Pleroma.Web.ActivityPub.ObjectValidators.LikeValidator
|
|
|
|
alias Pleroma.Web.ActivityPub.Utils
|
2019-10-23 12:18:05 +02:00
|
|
|
alias Pleroma.Web.CommonAPI
|
|
|
|
|
2019-10-17 18:36:52 +02:00
|
|
|
import Pleroma.Factory
|
|
|
|
|
2020-04-28 16:45:28 +02:00
|
|
|
describe "chat message create activities" do
|
|
|
|
test "it is invalid if the object already exists" do
|
|
|
|
user = insert(:user)
|
|
|
|
recipient = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post_chat_message(user, recipient, "hey")
|
|
|
|
object = Object.normalize(activity, false)
|
|
|
|
|
|
|
|
{:ok, create_data, _} = Builder.create(user, object.data["id"], [recipient.ap_id])
|
|
|
|
|
|
|
|
{:error, cng} = ObjectValidator.validate(create_data, [])
|
|
|
|
|
|
|
|
assert {:object, {"The object to create already exists", []}} in cng.errors
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-04-16 15:21:47 +02:00
|
|
|
describe "chat messages" do
|
|
|
|
setup do
|
2020-04-20 11:45:11 +02:00
|
|
|
clear_config([:instance, :remote_limit])
|
2020-04-16 15:21:47 +02:00
|
|
|
user = insert(:user)
|
|
|
|
recipient = insert(:user, local: false)
|
|
|
|
|
2020-04-20 14:08:54 +02:00
|
|
|
{:ok, valid_chat_message, _} = Builder.chat_message(user, recipient.ap_id, "hey :firefox:")
|
2020-04-16 15:21:47 +02:00
|
|
|
|
|
|
|
%{user: user, recipient: recipient, valid_chat_message: valid_chat_message}
|
|
|
|
end
|
|
|
|
|
|
|
|
test "validates for a basic object we build", %{valid_chat_message: valid_chat_message} do
|
2020-04-20 14:08:54 +02:00
|
|
|
assert {:ok, object, _meta} = ObjectValidator.validate(valid_chat_message, [])
|
|
|
|
|
|
|
|
assert object == valid_chat_message
|
2020-04-16 15:21:47 +02:00
|
|
|
end
|
|
|
|
|
2020-04-20 11:45:11 +02:00
|
|
|
test "does not validate if the message is longer than the remote_limit", %{
|
|
|
|
valid_chat_message: valid_chat_message
|
|
|
|
} do
|
|
|
|
Pleroma.Config.put([:instance, :remote_limit], 2)
|
|
|
|
refute match?({:ok, _object, _meta}, ObjectValidator.validate(valid_chat_message, []))
|
|
|
|
end
|
|
|
|
|
2020-04-22 12:48:52 +02:00
|
|
|
test "does not validate if the recipient is blocking the actor", %{
|
|
|
|
valid_chat_message: valid_chat_message,
|
|
|
|
user: user,
|
|
|
|
recipient: recipient
|
|
|
|
} do
|
|
|
|
Pleroma.User.block(recipient, user)
|
|
|
|
refute match?({:ok, _object, _meta}, ObjectValidator.validate(valid_chat_message, []))
|
|
|
|
end
|
|
|
|
|
2020-04-16 15:21:47 +02:00
|
|
|
test "does not validate if the actor or the recipient is not in our system", %{
|
|
|
|
valid_chat_message: valid_chat_message
|
|
|
|
} do
|
|
|
|
chat_message =
|
|
|
|
valid_chat_message
|
|
|
|
|> Map.put("actor", "https://raymoo.com/raymoo")
|
|
|
|
|
|
|
|
{:error, _} = ObjectValidator.validate(chat_message, [])
|
|
|
|
|
|
|
|
chat_message =
|
|
|
|
valid_chat_message
|
|
|
|
|> Map.put("to", ["https://raymoo.com/raymoo"])
|
|
|
|
|
|
|
|
{:error, _} = ObjectValidator.validate(chat_message, [])
|
|
|
|
end
|
|
|
|
|
|
|
|
test "does not validate for a message with multiple recipients", %{
|
|
|
|
valid_chat_message: valid_chat_message,
|
|
|
|
user: user,
|
|
|
|
recipient: recipient
|
|
|
|
} do
|
|
|
|
chat_message =
|
|
|
|
valid_chat_message
|
|
|
|
|> Map.put("to", [user.ap_id, recipient.ap_id])
|
|
|
|
|
|
|
|
assert {:error, _} = ObjectValidator.validate(chat_message, [])
|
|
|
|
end
|
|
|
|
|
|
|
|
test "does not validate if it doesn't concern local users" do
|
|
|
|
user = insert(:user, local: false)
|
|
|
|
recipient = insert(:user, local: false)
|
|
|
|
|
|
|
|
{:ok, valid_chat_message, _} = Builder.chat_message(user, recipient.ap_id, "hey")
|
|
|
|
assert {:error, _} = ObjectValidator.validate(valid_chat_message, [])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-10-17 18:36:52 +02:00
|
|
|
describe "likes" do
|
|
|
|
setup do
|
|
|
|
user = insert(:user)
|
|
|
|
{:ok, post_activity} = CommonAPI.post(user, %{"status" => "uguu"})
|
|
|
|
|
|
|
|
valid_like = %{
|
2019-10-17 19:35:31 +02:00
|
|
|
"to" => [user.ap_id],
|
|
|
|
"cc" => [],
|
2019-10-17 18:36:52 +02:00
|
|
|
"type" => "Like",
|
|
|
|
"id" => Utils.generate_activity_id(),
|
|
|
|
"object" => post_activity.data["object"],
|
|
|
|
"actor" => user.ap_id,
|
|
|
|
"context" => "a context"
|
|
|
|
}
|
|
|
|
|
|
|
|
%{valid_like: valid_like, user: user, post_activity: post_activity}
|
|
|
|
end
|
|
|
|
|
|
|
|
test "returns ok when called in the ObjectValidator", %{valid_like: valid_like} do
|
|
|
|
{:ok, object, _meta} = ObjectValidator.validate(valid_like, [])
|
|
|
|
|
|
|
|
assert "id" in Map.keys(object)
|
|
|
|
end
|
|
|
|
|
|
|
|
test "is valid for a valid object", %{valid_like: valid_like} do
|
|
|
|
assert LikeValidator.cast_and_validate(valid_like).valid?
|
|
|
|
end
|
|
|
|
|
|
|
|
test "it errors when the actor is missing or not known", %{valid_like: valid_like} do
|
|
|
|
without_actor = Map.delete(valid_like, "actor")
|
|
|
|
|
|
|
|
refute LikeValidator.cast_and_validate(without_actor).valid?
|
|
|
|
|
|
|
|
with_invalid_actor = Map.put(valid_like, "actor", "invalidactor")
|
|
|
|
|
|
|
|
refute LikeValidator.cast_and_validate(with_invalid_actor).valid?
|
|
|
|
end
|
|
|
|
|
|
|
|
test "it errors when the object is missing or not known", %{valid_like: valid_like} do
|
|
|
|
without_object = Map.delete(valid_like, "object")
|
|
|
|
|
|
|
|
refute LikeValidator.cast_and_validate(without_object).valid?
|
|
|
|
|
|
|
|
with_invalid_object = Map.put(valid_like, "object", "invalidobject")
|
|
|
|
|
|
|
|
refute LikeValidator.cast_and_validate(with_invalid_object).valid?
|
|
|
|
end
|
|
|
|
|
|
|
|
test "it errors when the actor has already like the object", %{
|
|
|
|
valid_like: valid_like,
|
|
|
|
user: user,
|
|
|
|
post_activity: post_activity
|
|
|
|
} do
|
|
|
|
_like = CommonAPI.favorite(user, post_activity.id)
|
|
|
|
|
|
|
|
refute LikeValidator.cast_and_validate(valid_like).valid?
|
|
|
|
end
|
|
|
|
|
|
|
|
test "it works when actor or object are wrapped in maps", %{valid_like: valid_like} do
|
|
|
|
wrapped_like =
|
|
|
|
valid_like
|
|
|
|
|> Map.put("actor", %{"id" => valid_like["actor"]})
|
|
|
|
|> Map.put("object", %{"id" => valid_like["object"]})
|
|
|
|
|
|
|
|
validated = LikeValidator.cast_and_validate(wrapped_like)
|
|
|
|
|
|
|
|
assert validated.valid?
|
|
|
|
|
|
|
|
assert {:actor, valid_like["actor"]} in validated.changes
|
|
|
|
assert {:object, valid_like["object"]} in validated.changes
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|