2018-12-23 21:11:29 +01:00
|
|
|
# Pleroma: A lightweight social networking server
|
2020-03-03 23:44:49 +01:00
|
|
|
# Copyright © 2017-2020 Pleroma Authors <https://pleroma.social/>
|
2018-12-23 21:11:29 +01:00
|
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
|
2017-03-29 01:39:01 +02:00
|
|
|
defmodule Pleroma.UploadTest do
|
|
|
|
use Pleroma.DataCase
|
|
|
|
|
2019-07-20 15:07:51 +02:00
|
|
|
import ExUnit.CaptureLog
|
|
|
|
|
2019-07-18 14:30:18 +02:00
|
|
|
alias Pleroma.Upload
|
|
|
|
alias Pleroma.Uploaders.Uploader
|
|
|
|
|
|
|
|
@upload_file %Plug.Upload{
|
|
|
|
content_type: "image/jpg",
|
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
|
|
|
filename: "image.jpg"
|
|
|
|
}
|
|
|
|
|
|
|
|
defmodule TestUploaderBase do
|
|
|
|
def put_file(%{path: path} = _upload, module_name) do
|
|
|
|
task_pid =
|
|
|
|
Task.async(fn ->
|
|
|
|
:timer.sleep(10)
|
|
|
|
|
|
|
|
{Uploader, path}
|
|
|
|
|> :global.whereis_name()
|
|
|
|
|> send({Uploader, self(), {:test}, %{}})
|
|
|
|
|
|
|
|
assert_receive {Uploader, {:test}}, 4_000
|
|
|
|
end)
|
|
|
|
|
|
|
|
Agent.start(fn -> task_pid end, name: module_name)
|
|
|
|
|
|
|
|
:wait_callback
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "Tried storing a file when http callback response success result" do
|
|
|
|
defmodule TestUploaderSuccess do
|
|
|
|
def http_callback(conn, _params),
|
|
|
|
do: {:ok, conn, {:file, "post-process-file.jpg"}}
|
|
|
|
|
|
|
|
def put_file(upload), do: TestUploaderBase.put_file(upload, __MODULE__)
|
|
|
|
end
|
|
|
|
|
|
|
|
setup do: [uploader: TestUploaderSuccess]
|
|
|
|
setup [:ensure_local_uploader]
|
|
|
|
|
|
|
|
test "it returns file" do
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
|
|
|
assert Upload.store(@upload_file) ==
|
|
|
|
{:ok,
|
|
|
|
%{
|
|
|
|
"name" => "image.jpg",
|
|
|
|
"type" => "Document",
|
2020-05-21 15:17:39 +02:00
|
|
|
"mediaType" => "image/jpeg",
|
2019-07-18 14:30:18 +02:00
|
|
|
"url" => [
|
|
|
|
%{
|
|
|
|
"href" => "http://localhost:4001/media/post-process-file.jpg",
|
|
|
|
"mediaType" => "image/jpeg",
|
|
|
|
"type" => "Link"
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}}
|
|
|
|
|
|
|
|
Task.await(Agent.get(TestUploaderSuccess, fn task_pid -> task_pid end))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "Tried storing a file when http callback response error" do
|
|
|
|
defmodule TestUploaderError do
|
|
|
|
def http_callback(conn, _params), do: {:error, conn, "Errors"}
|
|
|
|
|
|
|
|
def put_file(upload), do: TestUploaderBase.put_file(upload, __MODULE__)
|
|
|
|
end
|
|
|
|
|
|
|
|
setup do: [uploader: TestUploaderError]
|
|
|
|
setup [:ensure_local_uploader]
|
|
|
|
|
|
|
|
test "it returns error" do
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
2019-07-20 15:07:51 +02:00
|
|
|
|
|
|
|
assert capture_log(fn ->
|
|
|
|
assert Upload.store(@upload_file) == {:error, "Errors"}
|
|
|
|
Task.await(Agent.get(TestUploaderError, fn task_pid -> task_pid end))
|
|
|
|
end) =~
|
|
|
|
"[error] Elixir.Pleroma.Upload store (using Pleroma.UploadTest.TestUploaderError) failed: \"Errors\""
|
2019-07-18 14:30:18 +02:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "Tried storing a file when http callback doesn't response by timeout" do
|
|
|
|
defmodule(TestUploader, do: def(put_file(_upload), do: :wait_callback))
|
|
|
|
setup do: [uploader: TestUploader]
|
|
|
|
setup [:ensure_local_uploader]
|
|
|
|
|
|
|
|
test "it returns error" do
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
2019-07-20 15:07:51 +02:00
|
|
|
|
|
|
|
assert capture_log(fn ->
|
|
|
|
assert Upload.store(@upload_file) == {:error, "Uploader callback timeout"}
|
|
|
|
end) =~
|
|
|
|
"[error] Elixir.Pleroma.Upload store (using Pleroma.UploadTest.TestUploader) failed: \"Uploader callback timeout\""
|
2019-07-18 14:30:18 +02:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-11-23 17:40:45 +01:00
|
|
|
describe "Storing a file with the Local uploader" do
|
2018-12-05 11:37:06 +01:00
|
|
|
setup [:ensure_local_uploader]
|
2018-11-23 17:40:45 +01:00
|
|
|
|
2020-07-06 11:08:13 +02:00
|
|
|
test "does not allow descriptions longer than the post limit" do
|
|
|
|
clear_config([:instance, :description_limit], 2)
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
|
|
|
file = %Plug.Upload{
|
|
|
|
content_type: "image/jpg",
|
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
|
|
|
filename: "image.jpg"
|
|
|
|
}
|
|
|
|
|
|
|
|
{:error, :description_too_long} = Upload.store(file, description: "123")
|
|
|
|
end
|
|
|
|
|
2018-11-23 17:40:45 +01:00
|
|
|
test "returns a media url" do
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
|
|
|
file = %Plug.Upload{
|
|
|
|
content_type: "image/jpg",
|
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
|
|
|
filename: "image.jpg"
|
|
|
|
}
|
|
|
|
|
|
|
|
{:ok, data} = Upload.store(file)
|
|
|
|
|
|
|
|
assert %{"url" => [%{"href" => url}]} = data
|
|
|
|
|
|
|
|
assert String.starts_with?(url, Pleroma.Web.base_url() <> "/media/")
|
|
|
|
end
|
|
|
|
|
2018-04-16 01:37:51 +02:00
|
|
|
test "copies the file to the configured folder with deduping" do
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
2018-03-30 15:01:53 +02:00
|
|
|
file = %Plug.Upload{
|
|
|
|
content_type: "image/jpg",
|
2018-04-16 01:37:51 +02:00
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
2018-03-30 15:01:53 +02:00
|
|
|
filename: "an [image.jpg"
|
|
|
|
}
|
|
|
|
|
2018-11-29 21:11:45 +01:00
|
|
|
{:ok, data} = Upload.store(file, filters: [Pleroma.Upload.Filter.Dedupe])
|
2018-03-30 15:01:53 +02:00
|
|
|
|
2018-11-29 21:11:45 +01:00
|
|
|
assert List.first(data["url"])["href"] ==
|
|
|
|
Pleroma.Web.base_url() <>
|
2019-03-19 10:02:24 +01:00
|
|
|
"/media/e30397b58d226d6583ab5b8b3c5defb0c682bda5c31ef07a9f57c1c4986e3781.jpg"
|
2017-03-29 01:39:01 +02:00
|
|
|
end
|
2017-11-09 13:11:37 +01:00
|
|
|
|
2018-04-16 01:37:51 +02:00
|
|
|
test "copies the file to the configured folder without deduping" do
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
2018-03-30 15:01:53 +02:00
|
|
|
file = %Plug.Upload{
|
2018-04-16 01:37:51 +02:00
|
|
|
content_type: "image/jpg",
|
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
2018-03-30 15:01:53 +02:00
|
|
|
filename: "an [image.jpg"
|
|
|
|
}
|
|
|
|
|
2018-11-29 21:11:45 +01:00
|
|
|
{:ok, data} = Upload.store(file)
|
2018-04-16 01:37:51 +02:00
|
|
|
assert data["name"] == "an [image.jpg"
|
2017-11-09 13:11:37 +01:00
|
|
|
end
|
|
|
|
|
2018-04-16 01:37:51 +02:00
|
|
|
test "fixes incorrect content type" do
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
2018-03-30 15:01:53 +02:00
|
|
|
file = %Plug.Upload{
|
2018-04-16 01:37:51 +02:00
|
|
|
content_type: "application/octet-stream",
|
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
2018-03-30 15:01:53 +02:00
|
|
|
filename: "an [image.jpg"
|
|
|
|
}
|
|
|
|
|
2018-11-29 21:11:45 +01:00
|
|
|
{:ok, data} = Upload.store(file, filters: [Pleroma.Upload.Filter.Dedupe])
|
2018-04-16 01:37:51 +02:00
|
|
|
assert hd(data["url"])["mediaType"] == "image/jpeg"
|
2017-11-09 13:11:37 +01:00
|
|
|
end
|
2018-06-14 18:12:38 +02:00
|
|
|
|
|
|
|
test "adds missing extension" do
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
|
|
|
file = %Plug.Upload{
|
|
|
|
content_type: "image/jpg",
|
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
|
|
|
filename: "an [image"
|
|
|
|
}
|
|
|
|
|
2018-11-29 21:11:45 +01:00
|
|
|
{:ok, data} = Upload.store(file)
|
2018-06-14 18:12:38 +02:00
|
|
|
assert data["name"] == "an [image.jpg"
|
|
|
|
end
|
2018-06-21 20:04:12 +02:00
|
|
|
|
|
|
|
test "fixes incorrect file extension" do
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
|
|
|
file = %Plug.Upload{
|
|
|
|
content_type: "image/jpg",
|
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
|
|
|
filename: "an [image.blah"
|
|
|
|
}
|
|
|
|
|
2018-11-29 21:11:45 +01:00
|
|
|
{:ok, data} = Upload.store(file)
|
2018-06-21 20:04:12 +02:00
|
|
|
assert data["name"] == "an [image.jpg"
|
|
|
|
end
|
|
|
|
|
|
|
|
test "don't modify filename of an unknown type" do
|
|
|
|
File.cp("test/fixtures/test.txt", "test/fixtures/test_tmp.txt")
|
|
|
|
|
|
|
|
file = %Plug.Upload{
|
|
|
|
content_type: "text/plain",
|
|
|
|
path: Path.absname("test/fixtures/test_tmp.txt"),
|
|
|
|
filename: "test.txt"
|
|
|
|
}
|
|
|
|
|
2018-11-29 21:11:45 +01:00
|
|
|
{:ok, data} = Upload.store(file)
|
2018-06-21 20:04:12 +02:00
|
|
|
assert data["name"] == "test.txt"
|
|
|
|
end
|
2018-11-30 19:33:34 +01:00
|
|
|
|
|
|
|
test "copies the file to the configured folder with anonymizing filename" do
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
|
|
|
file = %Plug.Upload{
|
|
|
|
content_type: "image/jpg",
|
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
|
|
|
filename: "an [image.jpg"
|
|
|
|
}
|
|
|
|
|
|
|
|
{:ok, data} = Upload.store(file, filters: [Pleroma.Upload.Filter.AnonymizeFilename])
|
|
|
|
|
|
|
|
refute data["name"] == "an [image.jpg"
|
|
|
|
end
|
2019-01-14 19:29:38 +01:00
|
|
|
|
|
|
|
test "escapes invalid characters in url" do
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
|
|
|
file = %Plug.Upload{
|
|
|
|
content_type: "image/jpg",
|
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
|
|
|
filename: "an… image.jpg"
|
|
|
|
}
|
|
|
|
|
|
|
|
{:ok, data} = Upload.store(file)
|
|
|
|
[attachment_url | _] = data["url"]
|
|
|
|
|
2019-03-17 11:23:08 +01:00
|
|
|
assert Path.basename(attachment_url["href"]) == "an%E2%80%A6%20image.jpg"
|
2019-01-14 19:29:38 +01:00
|
|
|
end
|
2019-01-15 07:40:00 +01:00
|
|
|
|
2019-03-05 17:28:58 +01:00
|
|
|
test "escapes reserved uri characters" do
|
2019-01-15 07:40:00 +01:00
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
|
|
|
file = %Plug.Upload{
|
|
|
|
content_type: "image/jpg",
|
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
2019-03-05 17:28:58 +01:00
|
|
|
filename: ":?#[]@!$&\\'()*+,;=.jpg"
|
2019-01-15 07:40:00 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
{:ok, data} = Upload.store(file)
|
|
|
|
[attachment_url | _] = data["url"]
|
|
|
|
|
2019-03-05 17:28:58 +01:00
|
|
|
assert Path.basename(attachment_url["href"]) ==
|
2019-03-14 20:02:48 +01:00
|
|
|
"%3A%3F%23%5B%5D%40%21%24%26%5C%27%28%29%2A%2B%2C%3B%3D.jpg"
|
2019-01-15 07:40:00 +01:00
|
|
|
end
|
2017-03-29 01:39:01 +02:00
|
|
|
end
|
2019-07-24 17:35:25 +02:00
|
|
|
|
|
|
|
describe "Setting a custom base_url for uploaded media" do
|
2020-03-20 16:33:00 +01:00
|
|
|
setup do: clear_config([Pleroma.Upload, :base_url], "https://cache.pleroma.social")
|
2019-07-24 17:35:25 +02:00
|
|
|
|
|
|
|
test "returns a media url with configured base_url" do
|
|
|
|
base_url = Pleroma.Config.get([Pleroma.Upload, :base_url])
|
|
|
|
|
|
|
|
File.cp!("test/fixtures/image.jpg", "test/fixtures/image_tmp.jpg")
|
|
|
|
|
|
|
|
file = %Plug.Upload{
|
|
|
|
content_type: "image/jpg",
|
|
|
|
path: Path.absname("test/fixtures/image_tmp.jpg"),
|
|
|
|
filename: "image.jpg"
|
|
|
|
}
|
|
|
|
|
|
|
|
{:ok, data} = Upload.store(file, base_url: base_url)
|
|
|
|
|
|
|
|
assert %{"url" => [%{"href" => url}]} = data
|
|
|
|
|
|
|
|
refute String.starts_with?(url, base_url <> "/media/")
|
|
|
|
end
|
|
|
|
end
|
2017-03-29 01:39:01 +02:00
|
|
|
end
|