From 18668447d268524e39d9cc8812805053ef9c186e Mon Sep 17 00:00:00 2001
From: "Haelwenn (lanodan) Monnier" <contact@hacktivis.me>
Date: Sun, 25 Aug 2019 07:10:22 +0200
Subject: [PATCH 1/3] HttpRequestMock: Log mock errors as warnings

---
 test/support/http_request_mock.ex | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/test/support/http_request_mock.ex b/test/support/http_request_mock.ex
index 3adb5ba3b..00f4660c1 100644
--- a/test/support/http_request_mock.ex
+++ b/test/support/http_request_mock.ex
@@ -17,9 +17,14 @@ def request(
     with {:ok, res} <- apply(__MODULE__, method, [url, query, body, headers]) do
       res
     else
-      {_, _r} = error ->
-        # Logger.warn(r)
-        error
+      error ->
+        error = error
+
+        with {:error, message} <- error do
+          Logger.warn(message)
+        end
+
+        {_, _r} = error
     end
   end
 

From e22737ffb5f7e7c567802e2bcef5520e2759e734 Mon Sep 17 00:00:00 2001
From: "Haelwenn (lanodan) Monnier" <contact@hacktivis.me>
Date: Sun, 25 Aug 2019 07:33:46 +0200
Subject: [PATCH 2/3] HttpRequestMock: Improve non-implemented error message

---
 test/support/http_request_mock.ex | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/test/support/http_request_mock.ex b/test/support/http_request_mock.ex
index 00f4660c1..320244c75 100644
--- a/test/support/http_request_mock.ex
+++ b/test/support/http_request_mock.ex
@@ -975,7 +975,7 @@ def get("https://mstdn.jp/.well-known/webfinger?resource=acct:kpherox@mstdn.jp",
 
   def get(url, query, body, headers) do
     {:error,
-     "Not implemented the mock response for get #{inspect(url)}, #{query}, #{inspect(body)}, #{
+     "Mock response not implemented for GET #{inspect(url)}, #{query}, #{inspect(body)}, #{
        inspect(headers)
      }"}
   end
@@ -1037,7 +1037,10 @@ def post("http://404.site" <> _, _, _, _) do
      }}
   end
 
-  def post(url, _query, _body, _headers) do
-    {:error, "Not implemented the mock response for post #{inspect(url)}"}
+  def post(url, query, body, headers) do
+    {:error,
+     "Mock response not implemented for POST #{inspect(url)}, #{query}, #{inspect(body)}, #{
+       inspect(headers)
+     }"}
   end
 end

From 20c3f613d8574d67b1e5a47bf41f324101183398 Mon Sep 17 00:00:00 2001
From: "Haelwenn (lanodan) Monnier" <contact@hacktivis.me>
Date: Sun, 25 Aug 2019 08:55:29 +0200
Subject: [PATCH 3/3] HttpRequestMock: Remove useless `error = error`

---
 test/support/http_request_mock.ex | 2 --
 1 file changed, 2 deletions(-)

diff --git a/test/support/http_request_mock.ex b/test/support/http_request_mock.ex
index 320244c75..314b20a45 100644
--- a/test/support/http_request_mock.ex
+++ b/test/support/http_request_mock.ex
@@ -18,8 +18,6 @@ def request(
       res
     else
       error ->
-        error = error
-
         with {:error, message} <- error do
           Logger.warn(message)
         end