MRF: simple policy: refactor module to use guards and pattern matching

This commit is contained in:
William Pitcock 2018-09-10 01:06:44 +00:00
parent 97253df3ee
commit 88094c266d
1 changed files with 49 additions and 58 deletions

View File

@ -5,86 +5,77 @@ defmodule Pleroma.Web.ActivityPub.MRF.SimplePolicy do
@mrf_policy Application.get_env(:pleroma, :mrf_simple) @mrf_policy Application.get_env(:pleroma, :mrf_simple)
@accept Keyword.get(@mrf_policy, :accept) @accept Keyword.get(@mrf_policy, :accept)
defp check_accept(actor_info, object) do defp check_accept(%{host: actor_host} = actor_info, object)
if length(@accept) > 0 and not (actor_info.host in @accept) do when length(@accept) > 0 and not (actor_host in @accept) do
{:reject, nil} {:reject, nil}
else
{:ok, object}
end
end end
defp check_accept(actor_info, object), do: {:ok, object}
@reject Keyword.get(@mrf_policy, :reject) @reject Keyword.get(@mrf_policy, :reject)
defp check_reject(actor_info, object) do defp check_reject(%{host: actor_host} = actor_info, object) when actor_host in @reject do
if actor_info.host in @reject do {:reject, nil}
{:reject, nil}
else
{:ok, object}
end
end end
defp check_reject(actor_info, object), do: {:ok, object}
@media_removal Keyword.get(@mrf_policy, :media_removal) @media_removal Keyword.get(@mrf_policy, :media_removal)
defp check_media_removal(actor_info, %{"type" => activity_type} = object) defp check_media_removal(%{host: actor_host} = actor_info, %{"type" => "Create"} = object)
when activity_type == "Create" do when actor_host in @media_removal do
if actor_info.host in @media_removal do child_object = Map.delete(object["object"], "attachment")
child_object = Map.delete(object["object"], "attachment") object = Map.put(object, "object", child_object)
object = Map.put(object, "object", child_object) {:ok, object}
{:ok, object}
else
{:ok, object}
end
end end
defp check_media_removal(actor_info, object), do: {:ok, object} defp check_media_removal(actor_info, object), do: {:ok, object}
@media_nsfw Keyword.get(@mrf_policy, :media_nsfw) @media_nsfw Keyword.get(@mrf_policy, :media_nsfw)
defp check_media_nsfw(actor_info, %{"type" => activity_type} = object) defp check_media_nsfw(
when activity_type == "Create" do %{host: actor_host} = actor_info,
child_object = object["object"] %{
"type" => "Create",
if actor_info.host in @media_nsfw and child_object["attachment"] != nil and "object" => %{"attachment" => child_attachment} = child_object
length(child_object["attachment"]) > 0 do } = object
tags = (child_object["tag"] || []) ++ ["nsfw"] )
child_object = Map.put(child_object, "tags", tags) when actor_host in @media_nsfw and length(child_attachment) > 0 do
child_object = Map.put(child_object, "sensitive", true) tags = (child_object["tag"] || []) ++ ["nsfw"]
object = Map.put(object, "object", child_object) child_object = Map.put(child_object, "tags", tags)
{:ok, object} child_object = Map.put(child_object, "sensitive", true)
else object = Map.put(object, "object", child_object)
{:ok, object} {:ok, object}
end
end end
defp check_media_nsfw(actor_info, object), do: {:ok, object} defp check_media_nsfw(actor_info, object), do: {:ok, object}
@ftl_removal Keyword.get(@mrf_policy, :federated_timeline_removal) @ftl_removal Keyword.get(@mrf_policy, :federated_timeline_removal)
defp check_ftl_removal(actor_info, object) do defp check_ftl_removal(%{host: actor_host} = actor_info, object)
if actor_info.host in @ftl_removal do when actor_host in @ftl_removal do
user = User.get_by_ap_id(object["actor"]) user = User.get_by_ap_id(object["actor"])
# flip to/cc relationship to make the post unlisted # flip to/cc relationship to make the post unlisted
object = object =
if "https://www.w3.org/ns/activitystreams#Public" in object["to"] and if "https://www.w3.org/ns/activitystreams#Public" in object["to"] and
user.follower_address in object["cc"] do user.follower_address in object["cc"] do
to = to =
List.delete(object["to"], "https://www.w3.org/ns/activitystreams#Public") ++ List.delete(object["to"], "https://www.w3.org/ns/activitystreams#Public") ++
[user.follower_address] [user.follower_address]
cc = cc =
List.delete(object["cc"], user.follower_address) ++ List.delete(object["cc"], user.follower_address) ++
["https://www.w3.org/ns/activitystreams#Public"] ["https://www.w3.org/ns/activitystreams#Public"]
object object
|> Map.put("to", to) |> Map.put("to", to)
|> Map.put("cc", cc) |> Map.put("cc", cc)
else else
object object
end end
{:ok, object} {:ok, object}
else
{:ok, object}
end
end end
defp check_ftl_removal(actor_info, object), do: {:ok, object}
@impl true @impl true
def filter(object) do def filter(object) do
actor_info = URI.parse(object["actor"]) actor_info = URI.parse(object["actor"])