ChatControllerTest: Use new schema testing functions.

This commit is contained in:
lain 2020-04-27 12:19:27 +02:00
parent c86143ed73
commit d2bbea1a80
1 changed files with 8 additions and 50 deletions

View File

@ -5,14 +5,8 @@ defmodule Pleroma.Web.PleromaAPI.ChatControllerTest do
use Pleroma.Web.ConnCase, async: true use Pleroma.Web.ConnCase, async: true
alias Pleroma.Chat alias Pleroma.Chat
alias Pleroma.Web.ApiSpec
alias Pleroma.Web.ApiSpec.Schemas.ChatMessageResponse
alias Pleroma.Web.ApiSpec.Schemas.ChatMessagesResponse
alias Pleroma.Web.ApiSpec.Schemas.ChatResponse
alias Pleroma.Web.ApiSpec.Schemas.ChatsResponse
alias Pleroma.Web.CommonAPI alias Pleroma.Web.CommonAPI
import OpenApiSpex.TestAssertions
import Pleroma.Factory import Pleroma.Factory
describe "POST /api/v1/pleroma/chats/:id/messages" do describe "POST /api/v1/pleroma/chats/:id/messages" do
@ -27,11 +21,10 @@ test "it posts a message to the chat", %{conn: conn, user: user} do
conn conn
|> put_req_header("content-type", "application/json") |> put_req_header("content-type", "application/json")
|> post("/api/v1/pleroma/chats/#{chat.id}/messages", %{"content" => "Hallo!!"}) |> post("/api/v1/pleroma/chats/#{chat.id}/messages", %{"content" => "Hallo!!"})
|> json_response(200) |> json_response_and_validate_schema(200)
assert result["content"] == "Hallo!!" assert result["content"] == "Hallo!!"
assert result["chat_id"] == chat.id |> to_string() assert result["chat_id"] == chat.id |> to_string()
assert_schema(result, "ChatMessageResponse", ApiSpec.spec())
end end
end end
@ -50,18 +43,16 @@ test "it paginates", %{conn: conn, user: user} do
result = result =
conn conn
|> get("/api/v1/pleroma/chats/#{chat.id}/messages") |> get("/api/v1/pleroma/chats/#{chat.id}/messages")
|> json_response(200) |> json_response_and_validate_schema(200)
assert length(result) == 20 assert length(result) == 20
assert_schema(result, "ChatMessagesResponse", ApiSpec.spec())
result = result =
conn conn
|> get("/api/v1/pleroma/chats/#{chat.id}/messages?max_id=#{List.last(result)["id"]}") |> get("/api/v1/pleroma/chats/#{chat.id}/messages?max_id=#{List.last(result)["id"]}")
|> json_response(200) |> json_response_and_validate_schema(200)
assert length(result) == 10 assert length(result) == 10
assert_schema(result, "ChatMessagesResponse", ApiSpec.spec())
end end
test "it returns the messages for a given chat", %{conn: conn, user: user} do test "it returns the messages for a given chat", %{conn: conn, user: user} do
@ -78,7 +69,7 @@ test "it returns the messages for a given chat", %{conn: conn, user: user} do
result = result =
conn conn
|> get("/api/v1/pleroma/chats/#{chat.id}/messages") |> get("/api/v1/pleroma/chats/#{chat.id}/messages")
|> json_response(200) |> json_response_and_validate_schema(200)
result result
|> Enum.each(fn message -> |> Enum.each(fn message ->
@ -86,7 +77,6 @@ test "it returns the messages for a given chat", %{conn: conn, user: user} do
end) end)
assert length(result) == 3 assert length(result) == 3
assert_schema(result, "ChatMessagesResponse", ApiSpec.spec())
# Trying to get the chat of a different user # Trying to get the chat of a different user
result = result =
@ -107,10 +97,9 @@ test "it creates or returns a chat", %{conn: conn} do
result = result =
conn conn
|> post("/api/v1/pleroma/chats/by-ap-id/#{URI.encode_www_form(other_user.ap_id)}") |> post("/api/v1/pleroma/chats/by-ap-id/#{URI.encode_www_form(other_user.ap_id)}")
|> json_response(200) |> json_response_and_validate_schema(200)
assert result["id"] assert result["id"]
assert_schema(result, "ChatResponse", ApiSpec.spec())
end end
end end
@ -126,19 +115,16 @@ test "it paginates", %{conn: conn, user: user} do
result = result =
conn conn
|> get("/api/v1/pleroma/chats") |> get("/api/v1/pleroma/chats")
|> json_response(200) |> json_response_and_validate_schema(200)
assert length(result) == 20 assert length(result) == 20
assert_schema(result, "ChatsResponse", ApiSpec.spec())
result = result =
conn conn
|> get("/api/v1/pleroma/chats?max_id=#{List.last(result)["id"]}") |> get("/api/v1/pleroma/chats?max_id=#{List.last(result)["id"]}")
|> json_response(200) |> json_response_and_validate_schema(200)
assert length(result) == 10 assert length(result) == 10
assert_schema(result, "ChatsResponse", ApiSpec.spec())
end end
test "it return a list of chats the current user is participating in, in descending order of updates", test "it return a list of chats the current user is participating in, in descending order of updates",
@ -160,7 +146,7 @@ test "it return a list of chats the current user is participating in, in descend
result = result =
conn conn
|> get("/api/v1/pleroma/chats") |> get("/api/v1/pleroma/chats")
|> json_response(200) |> json_response_and_validate_schema(200)
ids = Enum.map(result, & &1["id"]) ids = Enum.map(result, & &1["id"])
@ -169,34 +155,6 @@ test "it return a list of chats the current user is participating in, in descend
chat_3.id |> to_string(), chat_3.id |> to_string(),
chat_1.id |> to_string() chat_1.id |> to_string()
] ]
assert_schema(result, "ChatsResponse", ApiSpec.spec())
end
end
describe "schemas" do
test "Chat example matches schema" do
api_spec = ApiSpec.spec()
schema = ChatResponse.schema()
assert_schema(schema.example, "ChatResponse", api_spec)
end
test "Chats example matches schema" do
api_spec = ApiSpec.spec()
schema = ChatsResponse.schema()
assert_schema(schema.example, "ChatsResponse", api_spec)
end
test "ChatMessage example matches schema" do
api_spec = ApiSpec.spec()
schema = ChatMessageResponse.schema()
assert_schema(schema.example, "ChatMessageResponse", api_spec)
end
test "ChatsMessage example matches schema" do
api_spec = ApiSpec.spec()
schema = ChatMessagesResponse.schema()
assert_schema(schema.example, "ChatMessagesResponse", api_spec)
end end
end end
end end