From 0091665f1ccbe26e4d9017317ef80947b5a0618c Mon Sep 17 00:00:00 2001 From: Boone Gorges Date: Tue, 13 Oct 2015 03:25:42 +0000 Subject: [PATCH] Correct expected counts in `WP_User_Query` 'number' test. The `create_many()` number should be padded by just one, to account for the user created by the test suite. Introduced in [35114]. We also don't have to create so many fixtures to run this test. See #28631. git-svn-id: https://develop.svn.wordpress.org/trunk@35123 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/user/query.php | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/phpunit/tests/user/query.php b/tests/phpunit/tests/user/query.php index f375a2294a..f3a0dcb4c5 100644 --- a/tests/phpunit/tests/user/query.php +++ b/tests/phpunit/tests/user/query.php @@ -438,20 +438,24 @@ class Tests_User_Query extends WP_UnitTestCase { * @ticket 28631 */ function test_number() { - $user_ids = $this->factory->user->create_many( 10 ); + // +1 for the default user created by the test suite. + $user_ids = $this->factory->user->create_many( 3 ); $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id() ) ); $users = $users->get_results(); - - $this->assertEquals( 12, count( $users ) ); + $this->assertEquals( 4, count( $users ) ); $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id(), 'number' => 10 ) ); $users = $users->get_results(); - $this->assertEquals( 10, count( $users ) ); + $this->assertEquals( 4, count( $users ) ); + + $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id(), 'number' => 2 ) ); + $users = $users->get_results(); + $this->assertEquals( 2, count( $users ) ); $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id(), 'number' => -1 ) ); $users = $users->get_results(); - $this->assertEquals( 12, count( $users ) ); + $this->assertEquals( 4, count( $users ) ); } /**