sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Custom fields: Allow for short-circuiting the meta key dropdown.

Browse Source 
Adds the `postmeta_form_keys` filter which allows for a potentially expensive query against postmeta to be avoided.

props ericmann, tollmanz, nacin.
see #33885.


git-svn-id: https://develop.svn.wordpress.org/trunk@35717 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Helen Hou-Sandi 2015-11-20 06:15:34 +00:00
parent 583a84b1db
commit 03bd31aedd
1 changed files with 27 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/wp-admin/includes/template-functions.php
View File

@ -577,21 +577,36 @@ function meta_form( $post = null ) {
$post = get_post( $post ); $post = get_post( $post );
/** /**
* Filter the number of custom fields to retrieve for the drop-down * Filter values for the meta key dropdown in the Custom Fields meta box.
* in the Custom Fields meta box.
* *
* @since 2.1.0 * Returning a non-null value will effectively short-circuit and avoid a
* potentially expensive query against postmeta.
* *
* @param int $limit Number of custom fields to retrieve. Default 30. * @since 4.4.0
*
* @param array|null $keys Pre-defined meta keys to be used in place of a postmeta query. Default null.
*/ */
$limit = apply_filters( 'postmeta_form_limit', 30 ); $keys = apply_filters( 'postmeta_form_keys', null );
$sql = "SELECT DISTINCT meta_key
FROM $wpdb->postmeta if ( null === $keys ) {
WHERE meta_key NOT BETWEEN '_' AND '_z' /**
HAVING meta_key NOT LIKE %s * Filter the number of custom fields to retrieve for the drop-down
ORDER BY meta_key * in the Custom Fields meta box.
LIMIT %d"; *
$keys = $wpdb->get_col( $wpdb->prepare( $sql, $wpdb->esc_like( '_' ) . '%', $limit ) ); * @since 2.1.0
*
* @param int $limit Number of custom fields to retrieve. Default 30.
*/
$limit = apply_filters( 'postmeta_form_limit', 30 );
$sql = "SELECT DISTINCT meta_key
FROM $wpdb->postmeta
WHERE meta_key NOT BETWEEN '_' AND '_z'
HAVING meta_key NOT LIKE %s
ORDER BY meta_key
LIMIT %d";
$keys = $wpdb->get_col( $wpdb->prepare( $sql, $wpdb->esc_like( '_' ) . '%', $limit ) );
}
if ( $keys ) { if ( $keys ) {
natcasesort( $keys ); natcasesort( $keys );
$meta_key_input_id = 'metakeyselect'; $meta_key_input_id = 'metakeyselect';