From 0433b87fdf7f11a7eefc13e8a221d35e3f7e9994 Mon Sep 17 00:00:00 2001 From: Helen Hou-Sandi Date: Tue, 16 Jun 2015 21:32:53 +0000 Subject: [PATCH] Media list table: Avoid PHP notices by using the proper variables. Also visually tightens up the row actions. props tyxla. fixes #32657. see #29881. git-svn-id: https://develop.svn.wordpress.org/trunk@32805 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/css/list-tables.css | 4 ++++ src/wp-admin/includes/class-wp-media-list-table.php | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/wp-admin/css/list-tables.css b/src/wp-admin/css/list-tables.css index ef191d86c1..a2808eb625 100644 --- a/src/wp-admin/css/list-tables.css +++ b/src/wp-admin/css/list-tables.css @@ -317,6 +317,10 @@ table.media .column-title .row-actions { margin-left: 70px; /* 60px image + margin */ } +table.media .column-title .media-info p { + margin-bottom: 0.2em; +} + /* @todo: pick a consistent list table selector */ .wp-list-table a { -webkit-transition: none; diff --git a/src/wp-admin/includes/class-wp-media-list-table.php b/src/wp-admin/includes/class-wp-media-list-table.php index 5ca6fafdc0..44e77a55cf 100644 --- a/src/wp-admin/includes/class-wp-media-list-table.php +++ b/src/wp-admin/includes/class-wp-media-list-table.php @@ -627,13 +627,14 @@ class WP_Media_List_Table extends WP_List_Table { * @since 4.3.0 * @access protected * - * @param object $link Link being acted upon. + * @param object $post Attachment being acted upon. * @param string $column_name Current column name. * @param string $primary Primary column name. - * @return string Row action output for links. + * @return string Row actions output for media attachments. */ - protected function handle_row_actions( $link, $column_name, $primary ) { + protected function handle_row_actions( $post, $column_name, $primary ) { if ( $primary === $column_name ) { + $att_title = _draft_or_post_title(); return $this->row_actions( $this->_get_row_actions( $post, $att_title ) ); } }