From 06329dc35e1c5e1b5d23a61745840b1528381e2e Mon Sep 17 00:00:00 2001 From: Joe McGill Date: Wed, 30 Aug 2017 15:03:08 +0000 Subject: [PATCH] Media: Ensure 'media_handle_upload()' returns 'WP_Error' on failure. This fixes an issue where failures when inserting the attachment post via `wp_insert_attachment()` would result in a return value of `0` instead of a `WP_Error` object, as documented. This is addressed by passing `true` as the fourth param (added in WP 4.7.0) when calling `wp_insert_attachment()`. Props mrasharirfan, flixos90. Fixes #41726. git-svn-id: https://develop.svn.wordpress.org/trunk@41323 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/media.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-admin/includes/media.php b/src/wp-admin/includes/media.php index 4a2e7c2e72..702a727ef4 100644 --- a/src/wp-admin/includes/media.php +++ b/src/wp-admin/includes/media.php @@ -378,7 +378,7 @@ function media_handle_upload($file_id, $post_id, $post_data = array(), $override unset( $attachment['ID'] ); // Save the data - $id = wp_insert_attachment($attachment, $file, $post_id); + $id = wp_insert_attachment( $attachment, $file, $post_id, true ); if ( !is_wp_error($id) ) { wp_update_attachment_metadata( $id, wp_generate_attachment_metadata( $id, $file ) ); }