From 076cbcdb71602fbb6a940aeda25a3bce0d517bdf Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Mon, 25 Jul 2016 15:27:43 +0000 Subject: [PATCH] Filesystem API: Prevent an endless self-calling loop in `wp_tempnam()`. Under certain conditions upgrades on Windows may fail because `wp_tempnam()` gets called in a loop. This can happen when `wp_tempnam()` is called with `\.maintenance` for the `$filename` parameter. The function strips the extension, in this case `.maintenance`, which results in an empty filename. Because it's empty, `wp_tempnam()` calls itself with `dirname( '\.maintenance' )`. On *nix systems this would be `"/"` which allows `wp_tempnam()` to fall back on `time()`. But on Windows it's `"\"`. This change adds the backslash to the list of characters which allow `wp_tempnam()` to fall back on `time()`. See [32322], [31936]. Fixes #33999. git-svn-id: https://develop.svn.wordpress.org/trunk@38151 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/file.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-admin/includes/file.php b/src/wp-admin/includes/file.php index 1250e36f6f..6bb61cff4e 100644 --- a/src/wp-admin/includes/file.php +++ b/src/wp-admin/includes/file.php @@ -168,7 +168,7 @@ function wp_tempnam( $filename = '', $dir = '' ) { $dir = get_temp_dir(); } - if ( empty( $filename ) || '.' == $filename || '/' == $filename ) { + if ( empty( $filename ) || '.' == $filename || '/' == $filename || '\\' == $filename ) { $filename = time(); }