From 07f14d643475a1779e70a4b619471589d730cbe1 Mon Sep 17 00:00:00 2001
From: Scott Taylor <wonderboymusic@git.wordpress.org>
Date: Fri, 28 Feb 2014 21:27:40 +0000
Subject: [PATCH] * Videos should always render at the same aspect ratio. *
 Don't force a pseudo-mime-type for `.m4v` files * Uniformly adapt to
 `$content_width` when setting video dimensions on the front end * Add the
 `height` attribute to the initial `<video>` in the video playlist JS template
 * Add some defensive/responsive CSS for a/v on the Edit Media page

See #27243.



git-svn-id: https://develop.svn.wordpress.org/trunk@27328 602fd350-edb4-49c9-b593-d223f7449a82
---
 src/wp-admin/css/media.css      |  9 ++++++
 src/wp-admin/includes/media.php | 15 ++++------
 src/wp-includes/media.php       | 53 +++++++++++++++++++++------------
 3 files changed, 49 insertions(+), 28 deletions(-)

diff --git a/src/wp-admin/css/media.css b/src/wp-admin/css/media.css
index 7d1a80ac31..71015d00ca 100644
--- a/src/wp-admin/css/media.css
+++ b/src/wp-admin/css/media.css
@@ -640,6 +640,15 @@ span.imgedit-scale-warn {
 	padding: 2px 10px;
 }
 
+audio, video {
+	display: inline-block;
+	max-width: 100%;
+}
+
+.mejs-container {
+	width: 100%;
+}
+
 /* =Media Queries
 -------------------------------------------------------------- */
 
diff --git a/src/wp-admin/includes/media.php b/src/wp-admin/includes/media.php
index d3f49e4484..e31edd7f49 100644
--- a/src/wp-admin/includes/media.php
+++ b/src/wp-admin/includes/media.php
@@ -2640,20 +2640,17 @@ function edit_form_image_editor( $post ) {
 		maybe_regenerate_attachment_metadata( $post );
 
 		$meta = wp_get_attachment_metadata( $attachment_id );
-		$w = ! empty( $meta['width'] ) ? min( $meta['width'], 600 ) : 0;
-		$h = 0;
-		if ( ! empty( $meta['height'] ) )
-			$h = $meta['height'];
-		if ( $h && $w < $meta['width'] )
+		$w = ! empty( $meta['width'] ) ? min( $meta['width'], 640 ) : 0;
+		$h = ! empty( $meta['height'] ) ? $meta['height'] : 0;
+		if ( $h && $w < $meta['width'] ) {
 			$h = round( ( $meta['height'] * $w ) / $meta['width'] );
+		}
 
 		$attr = array( 'src' => $att_url );
-
-		if ( ! empty( $meta['width' ] ) )
+		if ( ! empty( $w ) && ! empty( $h ) ) {
 			$attr['width'] = $w;
-
-		if ( ! empty( $meta['height'] ) )
 			$attr['height'] = $h;
+		}
 
 		echo wp_video_shortcode( $attr );
 
diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php
index a87ffd334e..41a85a8532 100644
--- a/src/wp-includes/media.php
+++ b/src/wp-includes/media.php
@@ -1058,7 +1058,13 @@ function wp_get_playlist( $attr, $type ) {
 		|| $images;
 
 	$outer = 22; // default padding and border of wrapper
+
+	$default_width = 640;
+	$default_height = 360;
+
 	$theme_width = $content_width - $outer;
+	$theme_height = round( ( $default_height * $theme_width ) / $default_width );
+
 	$data = compact( 'type', 'style' );
 
 	// don't pass strings to JSON, will be truthy in JS
@@ -1090,9 +1096,15 @@ function wp_get_playlist( $attr, $type ) {
 			}
 
 			if ( 'video' === $type ) {
-				$width = empty( $meta['width'] ) ? 640 : $meta['width'];
-				$height = empty( $meta['height'] ) ? 360 : $meta['height'];
-				$theme_height = round( ( $height * $theme_width ) / $width );
+				if ( ! empty( $meta['width'] ) && ! empty( $meta['height'] ) ) {
+					$width = $meta['width'];
+					$height = $meta['height'];
+					$theme_height = round( ( $height * $theme_width ) / $width );
+				} else {
+					$width = $default_width;
+					$height = $default_height;
+				}
+
 				$track['dimensions'] = array(
 					'original' => compact( 'width', 'height' ),
 					'resized' => array(
@@ -1165,7 +1177,11 @@ function wp_get_playlist( $attr, $type ) {
 	<?php if ( 'audio' === $type ): ?>
 	<div class="wp-playlist-current-item"></div>
 	<?php endif ?>
-	<<?php echo $safe_type ?> controls="controls" preload="metadata" width="<?php echo (int) $theme_width ?>"></<?php echo $safe_type ?>>
+	<<?php echo $safe_type ?> controls="controls" preload="metadata" width="<?php
+		echo (int) $theme_width;
+	?>"<?php if ( 'video' === $safe_type ):
+		echo ' height="', (int) $theme_height, '"';
+	endif; ?>></<?php echo $safe_type ?>>
 	<div class="wp-playlist-next"></div>
 	<div class="wp-playlist-prev"></div>
 	<noscript>
@@ -1444,8 +1460,8 @@ function wp_video_shortcode( $attr, $content = '' ) {
 		'loop'     => '',
 		'autoplay' => '',
 		'preload'  => 'metadata',
+		'width'    => 640,
 		'height'   => 360,
-		'width'    => empty( $content_width ) ? 640 : $content_width,
 	);
 
 	foreach ( $default_types as $type )
@@ -1454,17 +1470,19 @@ function wp_video_shortcode( $attr, $content = '' ) {
 	$atts = shortcode_atts( $defaults_atts, $attr, 'video' );
 	extract( $atts );
 
-	$w = $width;
-	$h = $height;
-	if ( is_admin() && $width > 600 )
-		$w = 600;
-	elseif ( ! is_admin() && $w > $defaults_atts['width'] )
-		$w = $defaults_atts['width'];
-
-	if ( $w < $width )
-		$height = round( ( $h * $w ) / $width );
-
-	$width = $w;
+	if ( is_admin() ) {
+		// shrink the video so it isn't huge in the admin
+		if ( $width > $defaults_atts['width'] ) {
+			$height = round( ( $height * $defaults_atts['width'] ) / $width );
+			$width = $defaults_atts['width'];
+		}
+	} else {
+		// if the video is bigger than the theme
+		if ( $width > $content_width ) {
+			$height = round( ( $height * $content_width ) / $width );
+			$width = $content_width;
+		}
+	}
 
 	$yt_pattern = '#^https?://(:?www\.)?(:?youtube\.com/watch|youtu\.be/)#';
 
@@ -1545,9 +1563,6 @@ function wp_video_shortcode( $attr, $content = '' ) {
 				$type = array( 'type' => 'video/youtube' );
 			} else {
 				$type = wp_check_filetype( $$fallback, wp_get_mime_types() );
-				// m4v sometimes shows up as video/mpeg which collides with mp4
-				if ( 'm4v' === $type['ext'] )
-					$type['type'] = 'video/m4v';
 			}
 			$html .= sprintf( $source, $type['type'], esc_url( $$fallback ) );
 		}