From 089276d5e811b76d8691a17467cf4f05765a0cc2 Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Tue, 20 Oct 2015 04:28:05 +0000 Subject: [PATCH] List Tables: revert the majority of [34467]. This was almost universally abhorred (the JS that disabled the bulk dropdowns). See #31634. git-svn-id: https://develop.svn.wordpress.org/trunk@35277 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/update-core.php | 2 +- src/wp-admin/js/list-table.js | 46 --------------------------- src/wp-includes/script-loader.php | 4 +-- 3 files changed, 2 insertions(+), 50 deletions(-) delete mode 100644 src/wp-admin/js/list-table.js diff --git a/src/wp-admin/includes/update-core.php b/src/wp-admin/includes/update-core.php index 0de0ab33c9..ac1ac37645 100644 --- a/src/wp-admin/includes/update-core.php +++ b/src/wp-admin/includes/update-core.php @@ -279,7 +279,7 @@ $_old_files = array( 'wp-admin/images/logo-login.gif', 'wp-admin/images/star.gif', 'wp-admin/js/list-table.dev.js', -//'wp-admin/js/list-table.js', // restored in 4.4 +'wp-admin/js/list-table.js', 'wp-includes/default-embeds.php', 'wp-includes/js/tinymce/plugins/wordpress/img/help.gif', 'wp-includes/js/tinymce/plugins/wordpress/img/more.gif', diff --git a/src/wp-admin/js/list-table.js b/src/wp-admin/js/list-table.js deleted file mode 100644 index 10b49a6ba1..0000000000 --- a/src/wp-admin/js/list-table.js +++ /dev/null @@ -1,46 +0,0 @@ -/*globals jQuery */ - -(function ($) { - 'use strict'; - - var listTable, - actions, - doActions; - - function getChecked() { - return listTable.find( 'table .check-column input[type="checkbox"]:checked' ); - } - - /** - * Enable and Disable Apply button in wp-list - * - * @param {jQuery.Event} e - */ - function setApplyButton( e ) { - var checked = getChecked().length; - - if ( 'SELECT' === e.target.tagName ) { - actions.val( e.target.value ); - } - - actions.prop( 'disabled', ! checked ); - doActions.prop( 'disabled', ! checked || -1 === parseInt( actions.val(), 10 ) ); - } - - $(document).ready(function () { - listTable = $( '.wp-list-table' ).closest( 'form' ); - if ( ! listTable.length ) { - return; - } - - actions = listTable.find( 'select[name="action"], select[name="action2"]' ) - .on( 'change', setApplyButton ) - .prop( 'disabled', true ); - - doActions = listTable.find( '#doaction, #doaction2' ) - .prop( 'disabled', true ); - - listTable.find( 'table' ).on( 'click', '.check-column :checkbox', setApplyButton ); - }); - -}(jQuery)); \ No newline at end of file diff --git a/src/wp-includes/script-loader.php b/src/wp-includes/script-loader.php index 09a9fac03e..72a7575053 100644 --- a/src/wp-includes/script-loader.php +++ b/src/wp-includes/script-loader.php @@ -77,7 +77,7 @@ function wp_default_scripts( &$scripts ) { 'secure' => (string) ( 'https' === parse_url( site_url(), PHP_URL_SCHEME ) ), ) ); - $scripts->add( 'common', "/wp-admin/js/common$suffix.js", array('jquery', 'hoverIntent', 'utils', 'list-table'), false, 1 ); + $scripts->add( 'common', "/wp-admin/js/common$suffix.js", array('jquery', 'hoverIntent', 'utils'), false, 1 ); did_action( 'init' ) && $scripts->localize( 'common', 'commonL10n', array( 'warnDelete' => __( "You are about to permanently delete these items.\n 'Cancel' to stop, 'OK' to delete." ), 'dismiss' => __( 'Dismiss this notice.' ), @@ -396,8 +396,6 @@ function wp_default_scripts( &$scripts ) { $scripts->add( 'user-suggest', "/wp-admin/js/user-suggest$suffix.js", array( 'jquery-ui-autocomplete' ), false, 1 ); - $scripts->add( 'list-table', "/wp-admin/js/list-table$suffix.js", array( 'jquery' ), false, 1 ); - $scripts->add( 'admin-bar', "/wp-includes/js/admin-bar$suffix.js", array(), false, 1 ); $scripts->add( 'wplink', "/wp-includes/js/wplink$suffix.js", array( 'jquery' ), false, 1 );