From 0c829777f279a2092f905b975806dac9ec40b883 Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Tue, 4 Oct 2016 06:58:36 +0000 Subject: [PATCH] Accessibility: Remove target=_blank from the Settings screens help tabs links. Stop taking control of users' browsers. Props rianrietveld. Fixes #38143. See #23432. git-svn-id: https://develop.svn.wordpress.org/trunk@38720 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/options-discussion.php | 4 ++-- src/wp-admin/options-general.php | 4 ++-- src/wp-admin/options-media.php | 4 ++-- src/wp-admin/options-permalink.php | 6 +++--- src/wp-admin/options-reading.php | 4 ++-- src/wp-admin/options-writing.php | 4 ++-- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/wp-admin/options-discussion.php b/src/wp-admin/options-discussion.php index 5b27e14a3c..0f92bfeff4 100644 --- a/src/wp-admin/options-discussion.php +++ b/src/wp-admin/options-discussion.php @@ -25,8 +25,8 @@ get_current_screen()->add_help_tab( array( get_current_screen()->set_help_sidebar( '

' . __('For more information:') . '

' . - '

' . __('Documentation on Discussion Settings') . '

' . - '

' . __('Support Forums') . '

' + '

' . __('Documentation on Discussion Settings') . '

' . + '

' . __('Support Forums') . '

' ); include( ABSPATH . 'wp-admin/admin-header.php' ); diff --git a/src/wp-admin/options-general.php b/src/wp-admin/options-general.php index 765c93f8d7..7b1c999277 100644 --- a/src/wp-admin/options-general.php +++ b/src/wp-admin/options-general.php @@ -42,8 +42,8 @@ get_current_screen()->add_help_tab( array( get_current_screen()->set_help_sidebar( '

' . __('For more information:') . '

' . - '

' . __('Documentation on General Settings') . '

' . - '

' . __('Support Forums') . '

' + '

' . __('Documentation on General Settings') . '

' . + '

' . __('Support Forums') . '

' ); include( ABSPATH . 'wp-admin/admin-header.php' ); diff --git a/src/wp-admin/options-media.php b/src/wp-admin/options-media.php index 2f7e0abbda..698b98dce6 100644 --- a/src/wp-admin/options-media.php +++ b/src/wp-admin/options-media.php @@ -31,8 +31,8 @@ get_current_screen()->add_help_tab( array( get_current_screen()->set_help_sidebar( '

' . __('For more information:') . '

' . - '

' . __('Documentation on Media Settings') . '

' . - '

' . __('Support Forums') . '

' + '

' . __('Documentation on Media Settings') . '

' . + '

' . __('Support Forums') . '

' ); include( ABSPATH . 'wp-admin/admin-header.php' ); diff --git a/src/wp-admin/options-permalink.php b/src/wp-admin/options-permalink.php index b6c52c517a..95c1a3e0ba 100644 --- a/src/wp-admin/options-permalink.php +++ b/src/wp-admin/options-permalink.php @@ -41,9 +41,9 @@ get_current_screen()->add_help_tab( array( get_current_screen()->set_help_sidebar( '

' . __('For more information:') . '

' . - '

' . __('Documentation on Permalinks Settings') . '

' . - '

' . __('Documentation on Using Permalinks') . '

' . - '

' . __('Support Forums') . '

' + '

' . __('Documentation on Permalinks Settings') . '

' . + '

' . __('Documentation on Using Permalinks') . '

' . + '

' . __('Support Forums') . '

' ); add_filter('admin_head', 'options_permalink_add_js'); diff --git a/src/wp-admin/options-reading.php b/src/wp-admin/options-reading.php index 7ad94fbad4..69c425f759 100644 --- a/src/wp-admin/options-reading.php +++ b/src/wp-admin/options-reading.php @@ -35,8 +35,8 @@ get_current_screen()->add_help_tab( array( get_current_screen()->set_help_sidebar( '

' . __('For more information:') . '

' . - '

' . __('Documentation on Reading Settings') . '

' . - '

' . __('Support Forums') . '

' + '

' . __('Documentation on Reading Settings') . '

' . + '

' . __('Support Forums') . '

' ); include( ABSPATH . 'wp-admin/admin-header.php' ); diff --git a/src/wp-admin/options-writing.php b/src/wp-admin/options-writing.php index 6248ba9e15..aa314f3bf2 100644 --- a/src/wp-admin/options-writing.php +++ b/src/wp-admin/options-writing.php @@ -42,8 +42,8 @@ if ( apply_filters( 'enable_update_services_configuration', true ) ) { get_current_screen()->set_help_sidebar( '

' . __('For more information:') . '

' . - '

' . __('Documentation on Writing Settings') . '

' . - '

' . __('Support Forums') . '

' + '

' . __('Documentation on Writing Settings') . '

' . + '

' . __('Support Forums') . '

' ); include( ABSPATH . 'wp-admin/admin-header.php' );