sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Media: Use wp_basename() to create attachment titles from filenames.

Browse Source 
In [38294], `pathinfo()` was used with the `PATHINFO_BASENAME` constant to
get the basename of the file to be used as an attachment title, which depends
on PHP locale and can cause issues with UTF-8 characters. This uses
`wp_basename()` instead, which is a more i18n-friendly version of `basename()`.

Props SergeyBiryukov.
Fixes #37608, #37989.

git-svn-id: https://develop.svn.wordpress.org/trunk@38673 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Joe McGill 2016-09-29 01:20:10 +00:00
parent ee7f970ffa
commit 0d0e2bf2ba
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wp-admin/includes/media.php
View File

@ -283,7 +283,9 @@ function media_handle_upload($file_id, $post_id, $post_data = array(), $override
if ( isset($file['error']) )
return new WP_Error( 'upload_error', $file['error'] );
$name = pathinfo( $_FILES[$file_id]['name'], PATHINFO_FILENAME );
$name = $_FILES[$file_id]['name'];
$ext = pathinfo( $name, PATHINFO_EXTENSION );
$name = wp_basename( $name, ".$ext" );
$url = $file['url'];
$type = $file['type'];