JavaScript: when starting Backbone history, stop if previously started.
Prevent a potential error condition if Backbone history is started by a plugin or theme before core tries to start it. Props tfrommen. Fixes #39612. git-svn-id: https://develop.svn.wordpress.org/trunk@40076 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
parent
0efaf5ddc5
commit
0d73b031c8
|
@ -411,6 +411,9 @@ window.wp = window.wp || {};
|
||||||
// Start the router if browser supports History API
|
// Start the router if browser supports History API
|
||||||
if ( window.history && window.history.pushState ) {
|
if ( window.history && window.history.pushState ) {
|
||||||
this.router = new revisions.Router({ model: this });
|
this.router = new revisions.Router({ model: this });
|
||||||
|
if ( Backbone.History.started ) {
|
||||||
|
Backbone.history.stop();
|
||||||
|
}
|
||||||
Backbone.history.start({ pushState: true });
|
Backbone.history.start({ pushState: true });
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|
|
@ -1431,6 +1431,9 @@ themes.Run = {
|
||||||
this.view.render();
|
this.view.render();
|
||||||
this.routes();
|
this.routes();
|
||||||
|
|
||||||
|
if ( Backbone.History.started ) {
|
||||||
|
Backbone.history.stop();
|
||||||
|
}
|
||||||
Backbone.history.start({
|
Backbone.history.start({
|
||||||
root: themes.data.settings.adminUrl,
|
root: themes.data.settings.adminUrl,
|
||||||
pushState: true,
|
pushState: true,
|
||||||
|
@ -1884,6 +1887,9 @@ themes.RunInstaller = {
|
||||||
this.view.render();
|
this.view.render();
|
||||||
this.routes();
|
this.routes();
|
||||||
|
|
||||||
|
if ( Backbone.History.started ) {
|
||||||
|
Backbone.history.stop();
|
||||||
|
}
|
||||||
Backbone.history.start({
|
Backbone.history.start({
|
||||||
root: themes.data.settings.adminUrl,
|
root: themes.data.settings.adminUrl,
|
||||||
pushState: true,
|
pushState: true,
|
||||||
|
|
|
@ -844,6 +844,9 @@ Manage = MediaFrame.extend({
|
||||||
startHistory: function() {
|
startHistory: function() {
|
||||||
// Verify pushState support and activate
|
// Verify pushState support and activate
|
||||||
if ( window.history && window.history.pushState ) {
|
if ( window.history && window.history.pushState ) {
|
||||||
|
if ( Backbone.History.started ) {
|
||||||
|
Backbone.history.stop();
|
||||||
|
}
|
||||||
Backbone.history.start( {
|
Backbone.history.start( {
|
||||||
root: window._wpMediaGridSettings.adminUrl,
|
root: window._wpMediaGridSettings.adminUrl,
|
||||||
pushState: true
|
pushState: true
|
||||||
|
|
|
@ -259,6 +259,9 @@ Manage = MediaFrame.extend({
|
||||||
startHistory: function() {
|
startHistory: function() {
|
||||||
// Verify pushState support and activate
|
// Verify pushState support and activate
|
||||||
if ( window.history && window.history.pushState ) {
|
if ( window.history && window.history.pushState ) {
|
||||||
|
if ( Backbone.History.started ) {
|
||||||
|
Backbone.history.stop();
|
||||||
|
}
|
||||||
Backbone.history.start( {
|
Backbone.history.start( {
|
||||||
root: window._wpMediaGridSettings.adminUrl,
|
root: window._wpMediaGridSettings.adminUrl,
|
||||||
pushState: true
|
pushState: true
|
||||||
|
|
Loading…
Reference in New Issue