From 0e067ab91e845b0dc7ada5a9ebea0684ec58c467 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Mon, 21 May 2018 11:58:19 +0000 Subject: [PATCH] Privacy: Correct the error check when creating an export folder in `wp_privacy_generate_personal_data_export_file()`. `wp_mkdir_p()` returns `false` on error, not a `WP_Error` object. Props birgire. Fixes #44158. git-svn-id: https://develop.svn.wordpress.org/trunk@43299 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/file.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/wp-admin/includes/file.php b/src/wp-admin/includes/file.php index b00752e095..dd528617e2 100644 --- a/src/wp-admin/includes/file.php +++ b/src/wp-admin/includes/file.php @@ -2026,9 +2026,8 @@ function wp_privacy_generate_personal_data_export_file( $request_id ) { $exports_dir = wp_privacy_exports_dir(); $exports_url = wp_privacy_exports_url(); - $result = wp_mkdir_p( $exports_dir ); - if ( is_wp_error( $result ) ) { - wp_send_json_error( $result->get_error_message() ); + if ( ! wp_mkdir_p( $exports_dir ) ) { + wp_send_json_error( __( 'Unable to create export folder.' ) ); } // Protect export folder from browsing.