From 0e5625e4fab7ff469dcc75ae0b2cf92e72619f69 Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Wed, 18 Nov 2015 19:04:33 +0000 Subject: [PATCH] List Tables: because we can never eradicate the existence of globals, ensure that `$comment` is hoisted into the global space inside `WP_Comments_List_Table::single_row()`. Fixes #34654. git-svn-id: https://develop.svn.wordpress.org/trunk@35674 602fd350-edb4-49c9-b593-d223f7449a82 --- .../includes/class-wp-comments-list-table.php | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/wp-admin/includes/class-wp-comments-list-table.php b/src/wp-admin/includes/class-wp-comments-list-table.php index 6560ff2c52..aafc37a0b3 100644 --- a/src/wp-admin/includes/class-wp-comments-list-table.php +++ b/src/wp-admin/includes/class-wp-comments-list-table.php @@ -474,12 +474,15 @@ class WP_Comments_List_Table extends WP_List_Table { } /** - * @global WP_Post $post + * @global WP_Post $post + * @global WP_Comment $comment * - * @param object $comment + * @param WP_Comment $item */ - public function single_row( $comment ) { - global $post; + public function single_row( $item ) { + global $post, $comment; + + $comment = $item; $the_comment_class = wp_get_comment_status( $comment ); if ( ! $the_comment_class ) { @@ -496,7 +499,7 @@ class WP_Comments_List_Table extends WP_List_Table { $this->single_row_columns( $comment ); echo "\n"; - $post = null; + unset( $post, $comment ); } /**