From 110b6f1bbea409b237b1743d1c467d7ab10cfc51 Mon Sep 17 00:00:00 2001
From: Ryan Boren <ryan@git.wordpress.org>
Date: Sun, 14 Sep 2008 05:37:54 +0000
Subject: [PATCH] Plugin install cleanups from Simek. fixes #7717

git-svn-id: https://develop.svn.wordpress.org/trunk@8884 602fd350-edb4-49c9-b593-d223f7449a82
---
 wp-admin/css/colors-classic.css      | 17 ++++++++++
 wp-admin/css/colors-fresh.css        | 23 +++++++++++--
 wp-admin/css/plugin-install.css      | 50 +++++++++++++++++-----------
 wp-admin/includes/plugin-install.php |  4 +--
 4 files changed, 69 insertions(+), 25 deletions(-)

diff --git a/wp-admin/css/colors-classic.css b/wp-admin/css/colors-classic.css
index 2d9cc47392..6882e35b1e 100644
--- a/wp-admin/css/colors-classic.css
+++ b/wp-admin/css/colors-classic.css
@@ -818,4 +818,21 @@ table.diff .diff-addedline ins {
 /* table vim shorcuts */
 .vim-current {
 	background-color: #CFEBF7 !important;
+}
+
+/* Install Plugins */
+.star-average, .star.star-rating {
+	background-color: #fc0;
+}
+
+div.star.select:hover {
+	background-color: #d00;
+}
+
+#plugin-information .fyi ul {
+	background-color: #eaf3fa;
+}
+
+#plugin-information .fyi h2.mainheader {
+	background-color: #cee1ef;
 }
\ No newline at end of file
diff --git a/wp-admin/css/colors-fresh.css b/wp-admin/css/colors-fresh.css
index 175a962740..2424c0685b 100644
--- a/wp-admin/css/colors-fresh.css
+++ b/wp-admin/css/colors-fresh.css
@@ -595,8 +595,8 @@ div#media-upload-error, .file-error, abbr.required, .widget-control-remove:hover
 
 /* Layout */
 .wp_themeSkin .mceStatusbar {
-	 color:#000;
-	 background-color: #eaf3fa;
+	color:#000;
+	background-color: #eaf3fa;
 }
 
 /* Button */
@@ -801,4 +801,21 @@ table.diff .diff-addedline ins {
 /* table vim shorcuts */
 .vim-current {
 	background-color: #E4F2FD !important;
-}
\ No newline at end of file
+}
+
+/* Install Plugins */
+.star-average, .star.star-rating {
+	background-color: #fc0;
+}
+
+div.star.select:hover {
+	background-color: #d00;
+}
+
+#plugin-information .fyi ul {
+	background-color: #eaf3fa;
+}
+
+#plugin-information .fyi h2.mainheader {
+	background-color: #cee1ef;
+}
diff --git a/wp-admin/css/plugin-install.css b/wp-admin/css/plugin-install.css
index af0bd334f0..6a60a15dde 100644
--- a/wp-admin/css/plugin-install.css
+++ b/wp-admin/css/plugin-install.css
@@ -5,29 +5,31 @@ div.star-holder {
 	width: 100px;
 	font-size: 19px;
 }
+
 div.star {
 	height: 100%;
 	position: absolute;
-	top: 0px;
-	left: 0px;
+	top: 0;
+	left: 0;
 	background-color: transparent;
 	letter-spacing: 1ex;
 	border: none;
 }
-div.star.select:hover { background-color: #d00; }
+
 .star1 { width: 20%; }
 .star2 { width: 40%; }
 .star3 { width: 60%; }
 .star4 { width: 80%; }
 .star5 { width: 100%; }
-.star-average, .star.star-rating { background-color: #fc0; }  /* TODO: Colour CSS file */
+
 .star img, div.star a, div.star a:hover, div.star a:visited {
 	display: block;
 	position: absolute;
-	right: 0px;
+	right: 0;
 	border: none;
 	text-decoration: none;
 }
+
 div.star img {
 	width: 19px;
 	height: 19px;
@@ -36,7 +38,6 @@ div.star img {
 }
 
 /* Start custom CSS */
-/* TODO: Move remaining colours to Colours CSS */
 /* Header on thickbox */
 #plugin-information-header {
 	margin: 0;
@@ -51,17 +52,23 @@ div.star img {
 	font-weight: normal;
 	margin: 0 5px;
 	position: absolute;
-	left: 0px;
+	left: 0;
 	bottom: -1px;
 }
 
 /* Install sidemenu */
-
 #plugin-information p.action-button {
 	width: 100%;
-	padding-bottom:0;
-	margin-bottom:0;
+	padding-bottom: 0;
+	margin-bottom: 0;
 	margin-top: 10px;
+	-moz-border-radius: 3px 0 0 3px;
+	-webkit-border-top-left-radius: 3px;
+	-khtml-border-top-left-radius: 3px;
+	border-top-left-radius: 3px;
+	-webkit-border-bottom-left-radius: 3px;
+	-khtml-border-bottom-left-radius: 3px;
+	border-top-bottom-radius: 3px;
 }
 
 #plugin-information .action-button a {
@@ -85,27 +92,30 @@ div.star img {
 
 #plugin-information .fyi h2 {
 	font-size: 0.9em;
-	margin-bottom: 0px;
-	margin-right: 0px;
+	margin-bottom: 0;
+	margin-right: 0;
 }
 
 #plugin-information .fyi h2.mainheader {
-	background-color: #cee1ef; /* TODO: Colour CSS file */
 	padding: 5px;
+	-moz-border-radius-topleft: 3px;
+	-webkit-border-top-left-radius: 3px;
+	-khtml-border-top-left-radius: 3px;
+	border-top-left-radius: 3px;
 }
 
 #plugin-information .fyi ul {
-	background-color: #eaf3fa; /* TODO: Colour CSS file */
-	padding-top: 10px;
-	padding-bottom: 10px;
-	padding-left: 7px;
-	padding-right: 5px;
-	margin: 0px;
+	padding: 10px 5px 10px 7px;
+	margin: 0;
 	list-style: none;
+	-moz-border-radius-bottomleft: 3px;
+	-webkit-border-bottom-left-radius: 3px;
+	-khtml-border-bottom-left-radius: 3px;
+	border-top-bottom-radius: 3px;
 }
 
 #plugin-information .fyi li {
-		margin-right: 0px;
+	margin-right: 0;
 }
 
 #plugin-information #section-holder {
diff --git a/wp-admin/includes/plugin-install.php b/wp-admin/includes/plugin-install.php
index 2172a8d610..e7242b8191 100644
--- a/wp-admin/includes/plugin-install.php
+++ b/wp-admin/includes/plugin-install.php
@@ -207,8 +207,8 @@ function display_plugins_table($plugins, $page = 1, $totalpages = 1){
 					$title = '<a target="_blank" href="' . $plugin['homepage'] . '">' . $title . '</a>';
 
 				$action_links = array();
-				$action_links[] = '<a href="' . admin_url('plugin-install.php?tab=plugin-information&plugin=' . $plugin['slug'] .
-									'&TB_iframe=true&width=600&height=800') . '" class="thickbox onclick" title="' .
+				$action_links[] = '<a href="' . admin_url('plugin-install.php?tab=plugin-information&amp;plugin=' . $plugin['slug'] .
+									'&amp;TB_iframe=true&amp;width=600&amp;height=800') . '" class="thickbox onclick" title="' .
 									attribute_escape($name) . '">' . __('Install') . '</a>';
 
 				$action_links = apply_filters('plugin_install_action_links', $action_links, $plugin);