From 12ac7b29989604562025aba1612498a0662b1d46 Mon Sep 17 00:00:00 2001 From: Konstantin Obenland Date: Tue, 12 Jan 2016 17:12:17 +0000 Subject: [PATCH] Themes: Clear floated theme cards on Themes page. Also maintains visual separation for Broken Themes table on searches that return no results. See [36171] for `.wp-clearfix`. Props 5um17, obenland, valendesigns, afercia. Fixes #26646. git-svn-id: https://develop.svn.wordpress.org/trunk@36270 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/css/themes.css | 5 +++-- src/wp-admin/js/theme.js | 3 +-- src/wp-admin/theme-install.php | 1 - src/wp-admin/themes.php | 3 +-- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/wp-admin/css/themes.css b/src/wp-admin/css/themes.css index 89fafd5f14..8256b86684 100644 --- a/src/wp-admin/css/themes.css +++ b/src/wp-admin/css/themes.css @@ -9,7 +9,6 @@ .theme-browser .themes { clear: both; - padding: 0 0 100px; } .themes-php .wrap h1 { @@ -1124,13 +1123,15 @@ p.no-themes { font-size: 18px; font-style: normal; margin: 0; - padding: 0; + padding: 100px 0; text-align: center; display: none; } + body.no-results p.no-themes { display: block; } + body.show-upload-theme p.no-themes { display: none !important; } diff --git a/src/wp-admin/js/theme.js b/src/wp-admin/js/theme.js index c655a5c18b..f74ecfdf7f 100644 --- a/src/wp-admin/js/theme.js +++ b/src/wp-admin/js/theme.js @@ -80,7 +80,6 @@ themes.view.Appearance = wp.Backbone.View.extend({ // Render and append this.view.render(); this.$el.empty().append( this.view.el ).addClass( 'rendered' ); - this.$el.append( '
' ); }, // Defines search element container @@ -838,7 +837,7 @@ themes.view.Preview = themes.view.Details.extend({ // a wrapper that will hold all the theme elements themes.view.Themes = wp.Backbone.View.extend({ - className: 'themes', + className: 'themes wp-clearfix', $overlay: $( 'div.theme-overlay' ), // Number to keep track of scroll position diff --git a/src/wp-admin/theme-install.php b/src/wp-admin/theme-install.php index 6bcd7cdc98..af038262c9 100644 --- a/src/wp-admin/theme-install.php +++ b/src/wp-admin/theme-install.php @@ -195,7 +195,6 @@ include(ABSPATH . 'wp-admin/admin-header.php');

-
errors() || ( 1 == count( $ct->errors()->get_error_codes() ) ?>
-
+
-