sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Streamline WP_User_Query unit tests.

Browse Source 
* Don't create user during setUp(), as it's not used in every test.
* Create fewer users in `get_all` and `orderby` tests.

See #30017.

git-svn-id: https://develop.svn.wordpress.org/trunk@30017 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges 2014-10-24 19:51:01 +00:00
parent 1fe9707760
commit 1345fdbe22
1 changed files with 29 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
tests/phpunit/tests/user/query.php
View File

@ -10,10 +10,6 @@ class Tests_User_Query extends WP_UnitTestCase {
function setUp() { function setUp() {
parent::setUp(); parent::setUp();
$this->user_id = $this->factory->user->create( array(
'role' => 'author'
) );
} }
function test_get_and_set() { function test_get_and_set() {
@ -78,60 +74,64 @@ class Tests_User_Query extends WP_UnitTestCase {
$this->assertEqualSets( array( $users[0], $users[2] ), $ids ); $this->assertEqualSets( array( $users[0], $users[2] ), $ids );
} }
function test_exclude() { public function test_exclude() {
$users = new WP_User_Query(); $users = $this->factory->user->create_many( 3, array(
$users->set( 'fields', '' ); 'role' => 'author',
$users->set( 'exclude', $this->user_id ); ) );
$users->prepare_query();
$users->query();
$ids = $users->get_results(); $q = new WP_User_Query( array(
$this->assertNotContains( $this->user_id, $ids ); 'fields' => '',
'exclude' => $users[1],
) );
$ids = $q->get_results();
// Indirect test in order to ignore default user created during installation.
$this->assertNotEmpty( $ids );
$this->assertNotContains( $users[1], $ids );
} }
function test_get_all() { public function test_get_all() {
$this->factory->user->create_many( 10, array( $this->factory->user->create_many( 3, array(
'role' => 'author' 'role' => 'author'
) ); ) );
$users = new WP_User_Query( array( 'blog_id' => get_current_blog_id() ) ); $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id() ) );
$users = $users->get_results(); $users = $users->get_results();
$this->assertEquals( 12, count( $users ) );
// +1 for the default user created during installation.
$this->assertEquals( 4, count( $users ) );
foreach ( $users as $user ) { foreach ( $users as $user ) {
$this->assertInstanceOf( 'WP_User', $user ); $this->assertInstanceOf( 'WP_User', $user );
} }
$users = new WP_User_Query( array( 'blog_id' => get_current_blog_id(), 'fields' => 'all_with_meta' ) ); $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id(), 'fields' => 'all_with_meta' ) );
$users = $users->get_results(); $users = $users->get_results();
$this->assertEquals( 12, count( $users ) ); $this->assertEquals( 4, count( $users ) );
foreach ( $users as $user ) { foreach ( $users as $user ) {
$this->assertInstanceOf( 'WP_User', $user ); $this->assertInstanceOf( 'WP_User', $user );
} }
} }
function test_orderby() { public function test_orderby_meta_value() {
$user_ids = $this->factory->user->create_many( 10, array( $users = $this->factory->user->create_many( 3, array(
'role' => 'author' 'role' => 'author'
) ); ) );
$names = array( 'd', 'f', 'n', 'f', 'd', 'j', 'r', 'p', 'h', 'g' ); update_user_meta( $users[0], 'last_name', 'Jones' );
update_user_meta( $users[1], 'last_name', 'Albert' );
update_user_meta( $users[2], 'last_name', 'Zorro' );
foreach ( $names as $i => $name ) $q = new WP_User_Query( array(
update_user_meta( $user_ids[$i], 'last_name', $name ); 'include' => $users,
$u = new WP_User_Query( array(
'include' => $user_ids,
'meta_key' => 'last_name', 'meta_key' => 'last_name',
'orderby' => 'meta_value', 'orderby' => 'meta_value',
'fields' => 'ids' 'fields' => 'ids'
) ); ) );
$values = array();
foreach ( $u->get_results() as $user )
$values[] = get_user_meta( $user, 'last_name', true );
sort( $names ); $expected = array( $users[1], $users[0], $users[2] );
$this->assertEquals( $names, $values ); $this->assertEquals( $expected, $q->get_results() );
} }
/** /**