sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Image Details modal: Remember the last state of the advanced toggle.

Browse Source 
props gcorne.
fixes #27366.


git-svn-id: https://develop.svn.wordpress.org/trunk@28125 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Andrew Nacin 2014-04-14 23:55:04 +00:00
parent a8efcb993f
commit 16490ce89c
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/wp-includes/js/media-views.js
View File

@ -6226,7 +6226,7 @@
events: _.defaults( media.view.Settings.AttachmentDisplay.prototype.events, { events: _.defaults( media.view.Settings.AttachmentDisplay.prototype.events, {
'click .edit-attachment': 'editAttachment', 'click .edit-attachment': 'editAttachment',
'click .replace-attachment': 'replaceAttachment', 'click .replace-attachment': 'replaceAttachment',
'click .advanced-toggle': 'toggleAdvanced', 'click .advanced-toggle': 'onToggleAdvanced',
'change [data-setting="customWidth"]': 'onCustomSize', 'change [data-setting="customWidth"]': 'onCustomSize',
'change [data-setting="customHeight"]': 'onCustomSize', 'change [data-setting="customHeight"]': 'onCustomSize',
'keyup [data-setting="customWidth"]': 'onCustomSize', 'keyup [data-setting="customWidth"]': 'onCustomSize',
@ -6238,6 +6238,7 @@
this.listenTo( this.model, 'change:url', this.updateUrl ); this.listenTo( this.model, 'change:url', this.updateUrl );
this.listenTo( this.model, 'change:link', this.toggleLinkSettings ); this.listenTo( this.model, 'change:link', this.toggleLinkSettings );
this.listenTo( this.model, 'change:size', this.toggleCustomSize ); this.listenTo( this.model, 'change:size', this.toggleCustomSize );
media.view.Settings.AttachmentDisplay.prototype.initialize.apply( this, arguments ); media.view.Settings.AttachmentDisplay.prototype.initialize.apply( this, arguments );
}, },
@ -6277,6 +6278,9 @@
postRender: function() { postRender: function() {
setTimeout( _.bind( this.resetFocus, this ), 10 ); setTimeout( _.bind( this.resetFocus, this ), 10 );
this.toggleLinkSettings(); this.toggleLinkSettings();
if ( getUserSetting( 'advImgDetails' ) === 'show' ) {
this.toggleAdvanced( true );
}
this.trigger( 'post-render' ); this.trigger( 'post-render' );
}, },
@ -6329,16 +6333,26 @@
} }
}, },
toggleAdvanced: function( event ) { onToggleAdvanced: function( event ) {
var $advanced = $( event.target ).closest( '.advanced-section' );
event.preventDefault(); event.preventDefault();
if ( $advanced.hasClass('advanced-visible') ) { this.toggleAdvanced();
},
toggleAdvanced: function( show ) {
var $advanced = this.$el.find( '.advanced-section' ),
mode;
if ( $advanced.hasClass('advanced-visible') || show === false ) {
$advanced.removeClass('advanced-visible'); $advanced.removeClass('advanced-visible');
$advanced.find('.advanced-settings').addClass('hidden'); $advanced.find('.advanced-settings').addClass('hidden');
mode = 'hide';
} else { } else {
$advanced.addClass('advanced-visible'); $advanced.addClass('advanced-visible');
$advanced.find('.advanced-settings').removeClass('hidden'); $advanced.find('.advanced-settings').removeClass('hidden');
mode = 'show';
} }
setUserSetting( 'advImgDetails', mode );
}, },
editAttachment: function( event ) { editAttachment: function( event ) {