sergiotarxz/Wordpress
sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove the once-placeholder-esque "tag hint", which has not worked in quite some time.

Browse Source 
It's not particularly useful, and adds visual noise when in place.

props welcher.
fixes #31485.


git-svn-id: https://develop.svn.wordpress.org/trunk@31607 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Helen Hou-Sandi 2015-03-03 21:52:35 +00:00
parent 6505f70ffb
commit 1c9b51a3e6
5 changed files with 2 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/wp-admin/css/edit.css
View File

@ -1063,15 +1063,6 @@ span.description,
13.0 - Tags 13.0 - Tags
------------------------------------------------------------------------------*/ ------------------------------------------------------------------------------*/
.tagsdiv {
margin-top: -8px;
}
#poststuff .taghint {
color: #aaa;
margin: 15px 0 -24px 12px;
}
#poststuff .tagsdiv .howto { #poststuff .tagsdiv .howto {
margin: 0 0 6px 0; margin: 0 0 6px 0;
} }
@ -1096,21 +1087,6 @@ span.description,
margin: 0 5px; margin: 0 5px;
} }
/* tag hints */
.taghint {
color: #aaa;
margin: -17px 0 0 7px;
visibility: hidden;
}
input.newtag ~ div.taghint {
visibility: visible;
}
input.newtag:focus ~ div.taghint {
visibility: hidden;
}
p.popular-tags { p.popular-tags {
border: none; border: none;
line-height: 2em; line-height: 2em;

3
src/wp-admin/css/press-this.css
View File

@ -258,8 +258,7 @@ th {
display: none; display: none;
} }
.screen-reader-text, .screen-reader-text {
.taghint {
position: absolute; position: absolute;
margin: -1px; margin: -1px;
padding: 0; padding: 0;

1
src/wp-admin/includes/class-wp-press-this.php
View File

@ -644,7 +644,6 @@ class WP_Press_This {
?> ?>
<div class="ajaxtag hide-if-no-js"> <div class="ajaxtag hide-if-no-js">
<label class="screen-reader-text" for="new-tag-post_tag"><?php _e( 'Tags' ); ?></label> <label class="screen-reader-text" for="new-tag-post_tag"><?php _e( 'Tags' ); ?></label>
<div class="taghint"><?php echo $taxonomy->labels->add_new_item; ?></div>
<p> <p>
<input type="text" id="new-tag-post_tag" name="newtag[post_tag]" class="newtag form-input-tip" size="16" autocomplete="off" value="" /> <input type="text" id="new-tag-post_tag" name="newtag[post_tag]" class="newtag form-input-tip" size="16" autocomplete="off" value="" />
<button type="button" class="button tagadd"><?php _e( 'Add' ); ?></button> <button type="button" class="button tagadd"><?php _e( 'Add' ); ?></button>

1
src/wp-admin/includes/meta-boxes.php
View File

@ -418,7 +418,6 @@ function post_tags_meta_box( $post, $box ) {
<?php if ( $user_can_assign_terms ) : ?> <?php if ( $user_can_assign_terms ) : ?>
<div class="ajaxtag hide-if-no-js"> <div class="ajaxtag hide-if-no-js">
<label class="screen-reader-text" for="new-tag-<?php echo $tax_name; ?>"><?php echo $box['title']; ?></label> <label class="screen-reader-text" for="new-tag-<?php echo $tax_name; ?>"><?php echo $box['title']; ?></label>
<div class="taghint"><?php echo $taxonomy->labels->add_new_item; ?></div>
<p><input type="text" id="new-tag-<?php echo $tax_name; ?>" name="newtag[<?php echo $tax_name; ?>]" class="newtag form-input-tip" size="16" autocomplete="off" value="" /> <p><input type="text" id="new-tag-<?php echo $tax_name; ?>" name="newtag[<?php echo $tax_name; ?>]" class="newtag form-input-tip" size="16" autocomplete="off" value="" />
<input type="button" class="button tagadd" value="<?php esc_attr_e('Add'); ?>" /></p> <input type="button" class="button tagadd" value="<?php esc_attr_e('Add'); ?>" /></p>
</div> </div>

11
src/wp-admin/js/tags-box.js
View File

@ -158,16 +158,7 @@ var tagBox, array_unique_noempty;
t.flushTags( $(this).closest('.tagsdiv') ); t.flushTags( $(this).closest('.tagsdiv') );
}); });
$('div.taghint', ajaxtag).click(function(){ $('input.newtag', ajaxtag).keyup(function(e){
$(this).css('visibility', 'hidden').parent().siblings('.newtag').focus();
});
$('input.newtag', ajaxtag).blur(function() {
if ( '' === this.value )
$(this).parent().siblings('.taghint').css('visibility', '');
}).focus(function(){
$(this).parent().siblings('.taghint').css('visibility', 'hidden');
}).keyup(function(e){
if ( 13 == e.which ) { if ( 13 == e.which ) {
tagBox.flushTags( $(this).closest('.tagsdiv') ); tagBox.flushTags( $(this).closest('.tagsdiv') );
return false; return false;