sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Correct the usage of the variable passed to `wp_install_download_language_pack()` and kill an unused local variable. Props michalzuber. Also avoid using the `$_REQUEST` superglobal in this function. See #28577. 

git-svn-id: https://develop.svn.wordpress.org/trunk@29016 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
John Blackbourn 2014-07-07 18:05:13 +00:00
parent e862e3cf6d
commit 1f51b720f0
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/wp-admin/includes/upgrade.php
View File

@ -2210,11 +2210,17 @@ function wp_get_available_translations() {
return false;
}
function wp_install_download_language_pack( $language ) {
/**
* [wp_install_download_language_pack description]
*
* @param string $lang [description]
* @return string|false [description]
*/
function wp_install_download_language_pack( $lang ) {
// Check if the language is already installed.
$available_languages = get_available_languages();
if ( in_array( $language->language, $available_languages ) ) {
return $language->language;
if ( in_array( $lang, $available_languages ) ) {
return $lang;
}
// Confirm the language is one we can download.
@ -2222,8 +2228,8 @@ function wp_install_download_language_pack( $language ) {
$loading_language = false;
if ( $body ) {
foreach ( $body['languages'] as $language ) {
if ( $language['language'] === $_REQUEST['language'] ) {
$loading_language = $_REQUEST['language'];
if ( $language['language'] === $lang ) {
$loading_language = $lang;
break;
}
}
@ -2237,7 +2243,6 @@ function wp_install_download_language_pack( $language ) {
require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
$skin = new Automatic_Upgrader_Skin;
$upgrader = new Language_Pack_Upgrader( $skin );
$options = array( 'clear_update_cache' => false );
$language->type = 'core';
/**
* @todo failures (such as non-direct FS)