sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

In Media Views, use this.listenTo( this.model, .... ) instead of this.model.on( .... ) to fix garbage collection and to avoid "ghost views."

Browse Source 
Fixes #30896.


git-svn-id: https://develop.svn.wordpress.org/trunk@31045 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor 2015-01-04 05:24:24 +00:00
parent 49d19a367a
commit 2003fcae83
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/wp-includes/js/media-views.js
View File

@ -4659,7 +4659,7 @@
delete this.options[ key ]; delete this.options[ key ];
}, this ); }, this );
this.model.on( 'change', this.render, this ); this.listenTo( this.model, 'change', this.render );
}, },
/** /**
* @returns {wp.media.view.Button} Returns itself to allow chaining * @returns {wp.media.view.Button} Returns itself to allow chaining
@ -5118,22 +5118,22 @@
} ); } );
if ( options.rerenderOnModelChange ) { if ( options.rerenderOnModelChange ) {
this.model.on( 'change', this.render, this ); this.listenTo( this.model, 'change', this.render );
} else { } else {
this.model.on( 'change:percent', this.progress, this ); this.listenTo( this.model, 'change:percent', this.progress );
} }
this.model.on( 'change:title', this._syncTitle, this ); this.listenTo( this.model, 'change:title', this._syncTitle );
this.model.on( 'change:caption', this._syncCaption, this ); this.listenTo( this.model, 'change:caption', this._syncCaption );
this.model.on( 'change:artist', this._syncArtist, this ); this.listenTo( this.model, 'change:artist', this._syncArtist );
this.model.on( 'change:album', this._syncAlbum, this ); this.listenTo( this.model, 'change:album', this._syncAlbum );
// Update the selection. // Update the selection.
this.model.on( 'add', this.select, this ); this.listenTo( this.model, 'add', this.select );
this.model.on( 'remove', this.deselect, this ); this.listenTo( this.model, 'remove', this.deselect );
if ( selection ) { if ( selection ) {
selection.on( 'reset', this.updateSelect, this ); selection.on( 'reset', this.updateSelect, this );
// Update the model's details view. // Update the model's details view.
this.model.on( 'selection:single selection:unsingle', this.details, this ); this.listenTo( this.model, 'selection:single selection:unsingle', this.details );
this.details( this.model, this.controller.state().get('selection') ); this.details( this.model, this.controller.state().get('selection') );
} }
@ -6015,7 +6015,7 @@
}; };
}, this ).sortBy('priority').pluck('el').value() ); }, this ).sortBy('priority').pluck('el').value() );
this.model.on( 'change', this.select, this ); this.listenTo( this.model, 'change', this.select );
this.select(); this.select();
}, },
@ -6818,7 +6818,7 @@
initialize: function() { initialize: function() {
this.model = this.model || new Backbone.Model(); this.model = this.model || new Backbone.Model();
this.model.on( 'change', this.updateChanges, this ); this.listenTo( this.model, 'change', this.updateChanges );
}, },
prepare: function() { prepare: function() {
@ -6935,7 +6935,7 @@
}); });
// Call 'initialize' directly on the parent class. // Call 'initialize' directly on the parent class.
media.view.Settings.prototype.initialize.apply( this, arguments ); media.view.Settings.prototype.initialize.apply( this, arguments );
this.model.on( 'change:link', this.updateLinkTo, this ); this.listenTo( this.model, 'change:link', this.updateLinkTo );
if ( attachment ) { if ( attachment ) {
attachment.on( 'change:uploading', this.render, this ); attachment.on( 'change:uploading', this.render, this );
@ -7185,7 +7185,7 @@
}, },
initialize: function() { initialize: function() {
this.model.on( 'change:compat', this.render, this ); this.listenTo( this.model, 'change:compat', this.render );
}, },
/** /**
* @returns {wp.media.view.AttachmentCompat} Returns itself to allow chaining * @returns {wp.media.view.AttachmentCompat} Returns itself to allow chaining
@ -7285,8 +7285,8 @@
this.views.set([ this.url ]); this.views.set([ this.url ]);
this.refresh(); this.refresh();
this.model.on( 'change:type', this.refresh, this ); this.listenTo( this.model, 'change:type', this.refresh );
this.model.on( 'change:loading', this.loading, this ); this.listenTo( this.model, 'change:loading', this.loading );
}, },
/** /**
@ -7372,7 +7372,7 @@
this.spinner = $('<span class="spinner" />')[0]; this.spinner = $('<span class="spinner" />')[0];
this.$el.append([ this.input, this.spinner ]); this.$el.append([ this.input, this.spinner ]);
this.model.on( 'change:url', this.render, this ); this.listenTo( this.model, 'change:url', this.render );
if ( this.model.get( 'url' ) ) { if ( this.model.get( 'url' ) ) {
_.delay( function () { _.delay( function () {
@ -7498,7 +7498,7 @@
* Call `initialize` directly on parent class with passed arguments * Call `initialize` directly on parent class with passed arguments
*/ */
media.view.Settings.AttachmentDisplay.prototype.initialize.apply( this, arguments ); media.view.Settings.AttachmentDisplay.prototype.initialize.apply( this, arguments );
this.model.on( 'change:url', this.updateImage, this ); this.listenTo( this.model, 'change:url', this.updateImage );
}, },
updateImage: function() { updateImage: function() {