sergiotarxz/Wordpress
sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Customize: Prevent the "Hide Controls" button label from overrunning the device preview buttons.

Browse Source 
Adds translation context for "Hide Controls" strings so translators can supply shorter strings where space is constrained. Adds styles to fade-out long the "Hide Controls" label where it would run into the device preview buttons.

Props westonruter, ocean90.
Fixes #38762.


git-svn-id: https://develop.svn.wordpress.org/trunk@39214 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Weston Ruter 2016-11-13 18:59:21 +00:00
parent 0c044ba8d9
commit 2158edc28f
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wp-admin/css/themes.css
View File

@ -1521,6 +1521,7 @@ body.full-overlay-active {
box-shadow: none !important; box-shadow: none !important;
-webkit-border-radius: 0 !important; -webkit-border-radius: 0 !important;
border-radius: 0 !important; border-radius: 0 !important;
z-index: -1; /* Below device buttons */
} }
.wp-core-ui .wp-full-overlay .collapse-sidebar:hover, .wp-core-ui .wp-full-overlay .collapse-sidebar:hover,
@ -1624,6 +1625,9 @@ body.full-overlay-active {
.wp-full-overlay-footer .devices { .wp-full-overlay-footer .devices {
float: right; float: right;
background: #eee;
-webkit-box-shadow: -20px 0 10px -5px #eee;
box-shadow: -20px 0 10px -5px #eee;
} }
.wp-full-overlay-footer .devices button { .wp-full-overlay-footer .devices button {

4
src/wp-admin/customize.php
View File

@ -191,9 +191,9 @@ do_action( 'customize_controls_print_scripts' );
<?php endforeach; ?> <?php endforeach; ?>
</div> </div>
<?php endif; ?> <?php endif; ?>
<button type="button" class="collapse-sidebar button" aria-expanded="true" aria-label="<?php esc_attr_e( 'Hide Controls' ); ?>"> <button type="button" class="collapse-sidebar button" aria-expanded="true" aria-label="<?php echo esc_attr( _x( 'Hide Controls', 'label for hide controls button without length constraints' ) ); ?>">
<span class="collapse-sidebar-arrow"></span> <span class="collapse-sidebar-arrow"></span>
<span class="collapse-sidebar-label"><?php _e( 'Hide Controls' ); ?></span> <span class="collapse-sidebar-label"><?php _ex( 'Hide Controls', 'short (~12 characters) label for hide controls button' ); ?></span>
</button> </button>
</div> </div>
</form> </form>

4
src/wp-includes/script-loader.php
View File

@ -467,8 +467,8 @@ function wp_default_scripts( &$scripts ) {
'notAllowed' => __( 'Sorry, you are not allowed to customize this site.' ), 'notAllowed' => __( 'Sorry, you are not allowed to customize this site.' ),
'previewIframeTitle' => __( 'Site Preview' ), 'previewIframeTitle' => __( 'Site Preview' ),
'loginIframeTitle' => __( 'Session expired' ), 'loginIframeTitle' => __( 'Session expired' ),
'collapseSidebar' => __( 'Hide Controls' ), 'collapseSidebar' => _x( 'Hide Controls', 'label for hide controls button without length constraints' ),
'expandSidebar' => __( 'Show Controls' ), 'expandSidebar' => _x( 'Show Controls', 'label for hide controls button without length constraints' ),
'untitledBlogName' => __( '(Untitled)' ), 'untitledBlogName' => __( '(Untitled)' ),
// Used for overriding the file types allowed in plupload. // Used for overriding the file types allowed in plupload.
'allowedFiles' => __( 'Allowed Files' ), 'allowedFiles' => __( 'Allowed Files' ),