In `views/button/select-mode-toggle`, don't hide the spinner with JS. This oversight is a symptom of the too-aggressive outside DOM handling that is happening in this view's `toggleBulkEditHandler` method.
Props afercia. Fixes #32324. git-svn-id: https://develop.svn.wordpress.org/trunk@32502 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
parent
8bcd566ee0
commit
23e40ef756
|
@ -311,7 +311,7 @@ SelectModeToggle = Button.extend({
|
||||||
// TODO: the Frame should be doing all of this.
|
// TODO: the Frame should be doing all of this.
|
||||||
if ( this.controller.isModeActive( 'select' ) ) {
|
if ( this.controller.isModeActive( 'select' ) ) {
|
||||||
this.model.set( 'text', l10n.cancelSelection );
|
this.model.set( 'text', l10n.cancelSelection );
|
||||||
children.not( '.media-button' ).hide();
|
children.not( '.spinner, .media-button' ).hide();
|
||||||
this.$el.show();
|
this.$el.show();
|
||||||
toolbar.$( '.delete-selected-button' ).removeClass( 'hidden' );
|
toolbar.$( '.delete-selected-button' ).removeClass( 'hidden' );
|
||||||
} else {
|
} else {
|
||||||
|
@ -319,7 +319,7 @@ SelectModeToggle = Button.extend({
|
||||||
this.controller.content.get().$el.removeClass( 'fixed' );
|
this.controller.content.get().$el.removeClass( 'fixed' );
|
||||||
toolbar.$el.css( 'width', '' );
|
toolbar.$el.css( 'width', '' );
|
||||||
toolbar.$( '.delete-selected-button' ).addClass( 'hidden' );
|
toolbar.$( '.delete-selected-button' ).addClass( 'hidden' );
|
||||||
children.not( '.spinner, .media-button' ).show();
|
children.not( '.media-button' ).show();
|
||||||
this.controller.state().get( 'selection' ).reset();
|
this.controller.state().get( 'selection' ).reset();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -47,7 +47,7 @@ SelectModeToggle = Button.extend({
|
||||||
// TODO: the Frame should be doing all of this.
|
// TODO: the Frame should be doing all of this.
|
||||||
if ( this.controller.isModeActive( 'select' ) ) {
|
if ( this.controller.isModeActive( 'select' ) ) {
|
||||||
this.model.set( 'text', l10n.cancelSelection );
|
this.model.set( 'text', l10n.cancelSelection );
|
||||||
children.not( '.media-button' ).hide();
|
children.not( '.spinner, .media-button' ).hide();
|
||||||
this.$el.show();
|
this.$el.show();
|
||||||
toolbar.$( '.delete-selected-button' ).removeClass( 'hidden' );
|
toolbar.$( '.delete-selected-button' ).removeClass( 'hidden' );
|
||||||
} else {
|
} else {
|
||||||
|
@ -55,7 +55,7 @@ SelectModeToggle = Button.extend({
|
||||||
this.controller.content.get().$el.removeClass( 'fixed' );
|
this.controller.content.get().$el.removeClass( 'fixed' );
|
||||||
toolbar.$el.css( 'width', '' );
|
toolbar.$el.css( 'width', '' );
|
||||||
toolbar.$( '.delete-selected-button' ).addClass( 'hidden' );
|
toolbar.$( '.delete-selected-button' ).addClass( 'hidden' );
|
||||||
children.not( '.spinner, .media-button' ).show();
|
children.not( '.media-button' ).show();
|
||||||
this.controller.state().get( 'selection' ).reset();
|
this.controller.state().get( 'selection' ).reset();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue