sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

I18N: In `wp_dropdown_languages()` rename the new `show_site_locale_default` argument to `show_option_site_default`. 

This makes it consistent with arguments of other `wp_dropdown_*()` functions.

Props SergeyBiryukov.
See #38632.
Fixes #38871.

git-svn-id: https://develop.svn.wordpress.org/trunk@39331 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Dominik Schilling (ocean90) 2016-11-21 16:14:01 +00:00
parent e2f67203bb
commit 257026f7a3
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-admin/user-edit.php
View File

@ -295,7 +295,7 @@ if ( $languages ) : ?>
'selected' => $user_locale,
'languages' => $languages,
'show_available_translations' => false,
'show_site_locale_default' => true
'show_option_site_default' => true
) );
?>
</td>

8
src/wp-includes/l10n.php
View File

@ -1108,7 +1108,7 @@ function wp_get_pomo_file_data( $po_file ) {
*
* @since 4.0.0
* @since 4.3.0 Introduced the `echo` argument.
* @since 4.7.0 Introduced the `show_site_locale_default` argument.
* @since 4.7.0 Introduced the `show_option_site_default` argument.
*
* @see get_available_languages()
* @see wp_get_available_translations()
@ -1126,7 +1126,7 @@ function wp_get_pomo_file_data( $po_file ) {
* @type bool|int $echo Whether to echo the generated markup. Accepts 0, 1, or their
* boolean equivalents. Default 1.
* @type bool $show_available_translations Whether to show available translations. Default true.
* @type bool $show_site_locale_default Whether to show an option to fall back to the site's locale. Default false.
* @type bool $show_option_site_default Whether to show an option to fall back to the site's locale. Default false.
* }
* @return string HTML content
*/
@ -1140,7 +1140,7 @@ function wp_dropdown_languages( $args = array() ) {
'selected' => '',
'echo' => 1,
'show_available_translations' => true,
'show_site_locale_default' => false,
'show_option_site_default' => false,
) );
// English (United States) uses an empty string for the value attribute.
@ -1191,7 +1191,7 @@ function wp_dropdown_languages( $args = array() ) {
$structure[] = '<optgroup label="' . esc_attr_x( 'Installed', 'translations' ) . '">';
}
if ( $args['show_site_locale_default'] ) {
if ( $args['show_option_site_default'] ) {
$structure[] = sprintf(
'<option value="site-default" data-installed="1"%s>%s</option>',
selected( 'site-default', $args['selected'], false ),

2
tests/phpunit/tests/l10n.php
View File

@ -110,7 +110,7 @@ class Tests_L10n extends WP_UnitTestCase {
'translations' => $this->wp_dropdown_languages_filter(),
'selected' => 'de_DE',
'echo' => false,
'show_site_locale_default' => true,
'show_option_site_default' => true,
);
$actual = wp_dropdown_languages( $args );