sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't suppress error messages in database function calls.

Browse Source 
Fixes #21870.


git-svn-id: https://develop.svn.wordpress.org/trunk@35860 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
ericlewis 2015-12-11 03:39:52 +00:00
parent 957697adf0
commit 26e7188154
1 changed files with 16 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
src/wp-includes/wp-db.php
View File

@ -1044,9 +1044,9 @@ class wpdb {
$dbh = $this->dbh; $dbh = $this->dbh;
if ( $this->use_mysqli ) { if ( $this->use_mysqli ) {
$success = @mysqli_select_db( $dbh, $db ); $success = mysqli_select_db( $dbh, $db );
} else { } else {
$success = @mysql_select_db( $db, $dbh ); $success = mysql_select_db( $db, $dbh );
} }
if ( ! $success ) { if ( ! $success ) {
$this->ready = false; $this->ready = false;
@ -1484,11 +1484,7 @@ class wpdb {
} }
} }
if ( WP_DEBUG ) { mysqli_real_connect( $this->dbh, $host, $this->dbuser, $this->dbpassword, null, $port, $socket, $client_flags );
mysqli_real_connect( $this->dbh, $host, $this->dbuser, $this->dbpassword, null, $port, $socket, $client_flags );
} else {
@mysqli_real_connect( $this->dbh, $host, $this->dbuser, $this->dbpassword, null, $port, $socket, $client_flags );
}
if ( $this->dbh->connect_errno ) { if ( $this->dbh->connect_errno ) {
$this->dbh = null; $this->dbh = null;
@ -1514,11 +1510,7 @@ class wpdb {
} }
} }
} else { } else {
if ( WP_DEBUG ) { $this->dbh = mysql_connect( $this->dbhost, $this->dbuser, $this->dbpassword, $new_link, $client_flags );
$this->dbh = mysql_connect( $this->dbhost, $this->dbuser, $this->dbpassword, $new_link, $client_flags );
} else {
$this->dbh = @mysql_connect( $this->dbhost, $this->dbuser, $this->dbpassword, $new_link, $client_flags );
}
} }
if ( ! $this->dbh && $allow_bail ) { if ( ! $this->dbh && $allow_bail ) {
@ -1589,11 +1581,11 @@ class wpdb {
*/ */
public function check_connection( $allow_bail = true ) { public function check_connection( $allow_bail = true ) {
if ( $this->use_mysqli ) { if ( $this->use_mysqli ) {
if ( @mysqli_ping( $this->dbh ) ) { if ( ! empty( $this->dbh ) && mysqli_ping( $this->dbh ) ) {
return true; return true;
} }
} else { } else {
if ( @mysql_ping( $this->dbh ) ) { if ( ! empty( $this->dbh ) && mysql_ping( $this->dbh ) ) {
return true; return true;
} }
} }
@ -1770,12 +1762,12 @@ class wpdb {
} else { } else {
$num_rows = 0; $num_rows = 0;
if ( $this->use_mysqli && $this->result instanceof mysqli_result ) { if ( $this->use_mysqli && $this->result instanceof mysqli_result ) {
while ( $row = @mysqli_fetch_object( $this->result ) ) { while ( $row = mysqli_fetch_object( $this->result ) ) {
$this->last_result[$num_rows] = $row; $this->last_result[$num_rows] = $row;
$num_rows++; $num_rows++;
} }
} elseif ( is_resource( $this->result ) ) { } elseif ( is_resource( $this->result ) ) {
while ( $row = @mysql_fetch_object( $this->result ) ) { while ( $row = mysql_fetch_object( $this->result ) ) {
$this->last_result[$num_rows] = $row; $this->last_result[$num_rows] = $row;
$num_rows++; $num_rows++;
} }
@ -1805,10 +1797,10 @@ class wpdb {
$this->timer_start(); $this->timer_start();
} }
if ( $this->use_mysqli ) { if ( ! empty( $this->dbh ) && $this->use_mysqli ) {
$this->result = @mysqli_query( $this->dbh, $query ); $this->result = mysqli_query( $this->dbh, $query );
} else { } elseif ( ! empty( $this->dbh ) ) {
$this->result = @mysql_query( $query, $this->dbh ); $this->result = mysql_query( $query, $this->dbh );
} }
$this->num_queries++; $this->num_queries++;
@ -3016,14 +3008,14 @@ class wpdb {
return; return;
if ( $this->use_mysqli ) { if ( $this->use_mysqli ) {
$num_fields = @mysqli_num_fields( $this->result ); $num_fields = mysqli_num_fields( $this->result );
for ( $i = 0; $i < $num_fields; $i++ ) { for ( $i = 0; $i < $num_fields; $i++ ) {
$this->col_info[ $i ] = @mysqli_fetch_field( $this->result ); $this->col_info[ $i ] = mysqli_fetch_field( $this->result );
} }
} else { } else {
$num_fields = @mysql_num_fields( $this->result ); $num_fields = mysql_num_fields( $this->result );
for ( $i = 0; $i < $num_fields; $i++ ) { for ( $i = 0; $i < $num_fields; $i++ ) {
$this->col_info[ $i ] = @mysql_fetch_field( $this->result, $i ); $this->col_info[ $i ] = mysql_fetch_field( $this->result, $i );
} }
} }
} }