sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Filesystem: Use a more unique filename in wp_tempnam() and get_filesystem_method().

Browse Source 
Using a filename which was generated from `time()` could cause two processes to try to use the same filename, causing unexpected behaviour.

Props jrchamp, bikecrazyy.
Fixes #42265.


git-svn-id: https://develop.svn.wordpress.org/trunk@42224 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Dion Hulse 2017-11-24 03:04:35 +00:00
parent 53eaf9f078
commit 26fb077862
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wp-admin/includes/file.php
View File

@ -624,7 +624,7 @@ function wp_tempnam( $filename = '', $dir = '' ) {
}
if ( empty( $filename ) || '.' == $filename || '/' == $filename || '\\' == $filename ) {
$filename = time();
$filename = uniqid();
}
// Use the basename of the given file without the extension as the name for the temporary directory
@ -1466,7 +1466,7 @@ function get_filesystem_method( $args = array(), $context = '', $allow_relaxed_f
if ( ! $method ) {
$temp_file_name = $context . 'temp-write-test-' . time();
$temp_file_name = $context . 'temp-write-test-' . str_replace( '.', '-', uniqid( '', true ) );
$temp_handle = @fopen($temp_file_name, 'w');
if ( $temp_handle ) {