From 285048ed3fe0f2d3ddb639a3603d57224bb5ec4e Mon Sep 17 00:00:00 2001
From: Jonathan Desrosiers <desrosj@git.wordpress.org>
Date: Fri, 16 Oct 2020 00:25:18 +0000
Subject: [PATCH] Build/Test Tools: Do not cancel previous workflow runs.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When a workflow is cancelled, it’s marked as a failure. This is not ideal because the commit attached to the workflow run will appear as though it introduced a problem, but this may not be true.

Because GitHub Actions work a bit differently than Travis builds, it’s unlikely that the same bottleneck will be encountered in workflows.

This change removes all workflow job steps that cancel previous workflows.

See #50401.

git-svn-id: https://develop.svn.wordpress.org/trunk@49168 602fd350-edb4-49c9-b593-d223f7449a82
---
 .github/workflows/end-to-end-tests.yml      | 6 ------
 .github/workflows/javascript-tests.yml      | 6 ------
 .github/workflows/phpunit-tests.yml         | 6 ------
 .github/workflows/verify-npm-on-windows.yml | 6 ------
 4 files changed, 24 deletions(-)

diff --git a/.github/workflows/end-to-end-tests.yml b/.github/workflows/end-to-end-tests.yml
index a9bbe81638..3c37381a52 100644
--- a/.github/workflows/end-to-end-tests.yml
+++ b/.github/workflows/end-to-end-tests.yml
@@ -16,7 +16,6 @@ jobs:
   # Runs the end-to-end test suite.
   #
   # Performs the following steps:
-  # - Cancels all previous workflow runs that have not completed.
   # - Set environment variables.
   # - Checks out the repository.
   # - Logs debug information about the runner container.
@@ -35,11 +34,6 @@ jobs:
     name: E2E Tests
     runs-on: ubuntu-latest
     steps:
-      - name: Cancel previous runs of this workflow
-        uses: styfle/cancel-workflow-action@0.5.0
-        with:
-          access_token: ${{ github.token }}
-
       - name: Configure environment variables
         run: |
           echo "PHP_FPM_UID=$(id -u)" >> $GITHUB_ENV
diff --git a/.github/workflows/javascript-tests.yml b/.github/workflows/javascript-tests.yml
index 0dbbb65599..40b36dfd9a 100644
--- a/.github/workflows/javascript-tests.yml
+++ b/.github/workflows/javascript-tests.yml
@@ -11,7 +11,6 @@ jobs:
   # Runs the QUnit tests for WordPress.
   #
   # Performs the following steps:
-  # - Cancels all previous workflow runs that have not completed.
   # - Checks out the repository.
   # - Logs debug information about the runner container.
   # - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
@@ -24,11 +23,6 @@ jobs:
     name: QUnit Tests
     runs-on: ubuntu-latest
     steps:
-      - name: Cancel previous runs of this workflow
-        uses: styfle/cancel-workflow-action@0.5.0
-        with:
-          access_token: ${{ github.token }}
-
       - name: Checkout repository
         uses: actions/checkout@v2
 
diff --git a/.github/workflows/phpunit-tests.yml b/.github/workflows/phpunit-tests.yml
index fd89460ddf..8db3446f44 100644
--- a/.github/workflows/phpunit-tests.yml
+++ b/.github/workflows/phpunit-tests.yml
@@ -22,7 +22,6 @@ jobs:
   # Sets up WordPress for testing or development use.
   #
   # Performs the following steps:
-  # - Cancels all previous workflow runs that have not completed.
   # - Checks out the repository.
   # - Checks out the WordPress Importer plugin (needed for the Core PHPUnit tests).
   # - Logs debug information about the runner container.
@@ -37,11 +36,6 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - name: Cancel previous runs of this workflow
-        uses: styfle/cancel-workflow-action@0.5.0
-        with:
-          access_token: ${{ github.token }}
-
       - name: Checkout repository
         uses: actions/checkout@v2
 
diff --git a/.github/workflows/verify-npm-on-windows.yml b/.github/workflows/verify-npm-on-windows.yml
index 22997f4348..8b6edc25ae 100644
--- a/.github/workflows/verify-npm-on-windows.yml
+++ b/.github/workflows/verify-npm-on-windows.yml
@@ -11,7 +11,6 @@ jobs:
   # Verifies that installing NPM dependencies and building WordPress works on Windows.
   #
   # Performs the following steps:
-  # - Cancels all previous workflow runs that have not completed.
   # - Checks out the repository.
   # - Logs debug information about the runner container.
   # - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
@@ -22,11 +21,6 @@ jobs:
     name: Tests NPM on Windows
     runs-on: windows-latest
     steps:
-      - name: Cancel previous runs of this workflow
-        uses: styfle/cancel-workflow-action@0.5.0
-        with:
-          access_token: ${{ github.token }}
-
       - name: Checkout repository
         uses: actions/checkout@v2