sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Twenty Nineteen: Make sure links are followed on touchend, not touchstart.

Browse Source 
The theme's original navigation JavaScript was making it so all links on a site were immediately followed on touchstart when using a touch-enabled device. This update makes sure links are followed at touchend, to improve usability and menu behavior.

Already committed to the 5.0 branch in [44357].

Props anevins, panchen, kjellr.
Fixes #45510.



git-svn-id: https://develop.svn.wordpress.org/trunk@44358 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
laurelfulford 2018-12-21 21:35:48 +00:00
parent 30dcae9e2d
commit 29cb0f5ad5
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/wp-content/themes/twentynineteen/js/touch-keyboard-navigation.js
View File

@ -219,19 +219,9 @@
var url = event.target.getAttribute( 'href' ) ? event.target.getAttribute( 'href' ) : ''; var url = event.target.getAttribute( 'href' ) ? event.target.getAttribute( 'href' ) : '';
// If there’s a link, go to it on touchend
if ( '#' !== url && '' !== url ) {
window.location = url;
// Open submenu if url is # // Open submenu if url is #
} else if ( '#' === url && event.target.nextSibling.matches('.submenu-expand') ) { if ( '#' === url && event.target.nextSibling.matches('.submenu-expand') ) {
openSubMenu( event.target ); openSubMenu( event.target );
// Prevent default touch events
} else {
event.preventDefault();
} }
} }