From 2ce93f915d802715841f43fa148b5961c29213fb Mon Sep 17 00:00:00 2001
From: Sergey Biryukov <sergeybiryukov@git.wordpress.org>
Date: Wed, 2 Jul 2014 01:27:07 +0000
Subject: [PATCH] Clarify the docs and add more unit tests for
 wp_set_object_terms().

props DrewAPicture.
fixes #26570.

git-svn-id: https://develop.svn.wordpress.org/trunk@28951 602fd350-edb4-49c9-b593-d223f7449a82
---
 src/wp-includes/taxonomy.php | 14 +++---
 tests/phpunit/tests/term.php | 88 ++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+), 7 deletions(-)

diff --git a/src/wp-includes/taxonomy.php b/src/wp-includes/taxonomy.php
index 426e8decce..73e9214188 100644
--- a/src/wp-includes/taxonomy.php
+++ b/src/wp-includes/taxonomy.php
@@ -2617,14 +2617,14 @@ function wp_insert_term( $term, $taxonomy, $args = array() ) {
  * @since 2.3.0
  * @uses wp_remove_object_terms()
  *
- * @param int $object_id The object to relate to.
- * @param array|int|string $terms The slug or id of the term, will replace all existing
- * related terms in this taxonomy.
- * @param array|string $taxonomy The context in which to relate the term to the object.
- * @param bool $append If false will delete difference of terms.
- * @return array|WP_Error Affected Term IDs
+ * @param int              $object_id The object to relate to.
+ * @param array|int|string $terms     A single term slug, single term id, or array of either term slugs or ids.
+ *                                    Will replace all existing related terms in this taxonomy.
+ * @param array|string     $taxonomy  The context in which to relate the term to the object.
+ * @param bool             $append    If false will delete difference of terms.
+ * @return array|WP_Error Affected Term IDs.
  */
-function wp_set_object_terms($object_id, $terms, $taxonomy, $append = false) {
+function wp_set_object_terms( $object_id, $terms, $taxonomy, $append = false ) {
 	global $wpdb;
 
 	$object_id = (int) $object_id;
diff --git a/tests/phpunit/tests/term.php b/tests/phpunit/tests/term.php
index 0768cbda52..ee1e27d210 100644
--- a/tests/phpunit/tests/term.php
+++ b/tests/phpunit/tests/term.php
@@ -109,6 +109,94 @@ class Tests_Term extends WP_UnitTestCase {
 		return $terms;
 	}
 
+	/**
+	 * @ticket 26570
+	 */
+	function test_set_object_terms() {
+		$non_hier = rand_str( 10 );
+		$hier     = rand_str( 10 );
+
+		// Register taxonomies
+		register_taxonomy( $non_hier, array() );
+		register_taxonomy( $hier, array( 'hierarchical' => true ) );
+
+		// Create a post.
+		$post_id = $this->factory->post->create();
+
+		/*
+		 * Set a single term (non-hierarchical) by ID.
+		 */
+		$tag = wp_insert_term( 'Foo', $non_hier );
+		$this->assertFalse( has_term( $tag['term_id'], $non_hier, $post_id ) );
+
+		wp_set_object_terms( $post_id, $tag['term_id'], $non_hier );
+		$this->assertTrue( has_term( $tag['term_id'], $non_hier, $post_id ) );
+
+		/*
+		 * Set a single term (non-hierarchical) by slug.
+		 */
+		$tag = wp_insert_term( 'Bar', $non_hier );
+		$tag = get_term( $tag['term_id'], $non_hier );
+
+		$this->assertFalse( has_term( $tag->slug, $non_hier, $post_id ) );
+
+		wp_set_object_terms( $post_id, $tag->slug, $non_hier );
+		$this->assertTrue( has_term( $tag->slug, $non_hier, $post_id ) );
+
+		/*
+		 * Set a single term (hierarchical) by ID.
+		 */
+		$cat = wp_insert_term( 'Baz', $hier );
+		$this->assertFalse( has_term( $cat['term_id'], $hier, $post_id ) );
+
+		wp_set_object_terms( $post_id, $cat['term_id'], $hier );
+		$this->assertTrue( has_term( $cat['term_id'], $hier, $post_id ) );
+
+		/*
+		 * Set a single term (hierarchical) by slug.
+		 */
+		$cat = wp_insert_term( 'Qux', $hier );
+		$cat = get_term( $cat['term_id'], $hier );
+
+		$this->assertFalse( has_term( $cat->slug, $hier, $post_id ) );
+
+		wp_set_object_terms( $post_id, $cat->slug, $hier );
+		$this->assertTrue( has_term( $cat->slug, $hier, $post_id ) );
+
+		/*
+		 * Set an array of term IDs (non-hierarchical) by ID.
+		 */
+		$tag1 = wp_insert_term( '_tag1', $non_hier );
+		$this->assertFalse( has_term( $tag1['term_id'], $non_hier, $post_id ) );
+
+		$tag2 = wp_insert_term( '_tag2', $non_hier );
+		$this->assertFalse( has_term( $tag2['term_id'], $non_hier, $post_id ) );
+
+		$tag3 = wp_insert_term( '_tag3', $non_hier );
+		$this->assertFalse( has_term( $tag3['term_id'], $non_hier, $post_id ) );
+
+		wp_set_object_terms( $post_id, array( $tag1['term_id'], $tag2['term_id'], $tag3['term_id'] ), $non_hier );
+		$this->assertTrue( has_term( array( $tag1['term_id'], $tag2['term_id'], $tag3['term_id'] ), $non_hier, $post_id ) );
+
+		/*
+		 * Set an array of term slugs (hierarchical) by slug.
+		 */
+		$cat1 = wp_insert_term( '_cat1', $hier );
+		$cat1 = get_term( $cat1['term_id'], $hier );
+		$this->assertFalse( has_term( $cat1->slug, $hier, $post_id ) );
+
+		$cat2 = wp_insert_term( '_cat2', $hier );
+		$cat2 = get_term( $cat2['term_id'], $hier );
+		$this->assertFalse( has_term( $cat2->slug, $hier, $post_id ) );
+
+		$cat3 = wp_insert_term( '_cat3', $hier );
+		$cat3 = get_term( $cat3['term_id'], $hier );
+		$this->assertFalse( has_term( $cat3->slug, $hier, $post_id ) );
+
+		wp_set_object_terms( $post_id, array( $cat1->slug, $cat2->slug, $cat3->slug ), $hier );
+		$this->assertTrue( has_term( array( $cat1->slug, $cat2->slug, $cat3->slug ), $hier, $post_id ) );
+	}
+
 	function test_set_object_terms_by_id() {
 		$ids = $this->factory->post->create_many(5);