From 2e54e6cb85ddcf8e96b4bec38c918aba45e2f711 Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Wed, 1 Jun 2016 17:38:04 +0000 Subject: [PATCH] Accessibility: match the visual and tab order in the Media Modal grid. By moving the Details sidebar after the attachments grid, the tab order is greatly improved for keyboard users and matches the logical and visual order. Fixes #36909. git-svn-id: https://develop.svn.wordpress.org/trunk@37610 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/js/media-views.js | 4 ++-- src/wp-includes/js/media/views/attachments/browser.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wp-includes/js/media-views.js b/src/wp-includes/js/media-views.js index 0e1ea805ec..91b5d3a5b7 100644 --- a/src/wp-includes/js/media-views.js +++ b/src/wp-includes/js/media-views.js @@ -3772,11 +3772,11 @@ AttachmentsBrowser = View.extend({ this.controller.on( 'toggle:upload:attachment', this.toggleUploader, this ); this.controller.on( 'edit:selection', this.editSelection ); this.createToolbar(); + this.createUploader(); + this.createAttachments(); if ( this.options.sidebar ) { this.createSidebar(); } - this.createUploader(); - this.createAttachments(); this.updateContent(); if ( ! this.options.sidebar || 'errors' === this.options.sidebar ) { diff --git a/src/wp-includes/js/media/views/attachments/browser.js b/src/wp-includes/js/media/views/attachments/browser.js index 7ca001bb1f..819d251b3c 100644 --- a/src/wp-includes/js/media/views/attachments/browser.js +++ b/src/wp-includes/js/media/views/attachments/browser.js @@ -41,11 +41,11 @@ AttachmentsBrowser = View.extend({ this.controller.on( 'toggle:upload:attachment', this.toggleUploader, this ); this.controller.on( 'edit:selection', this.editSelection ); this.createToolbar(); + this.createUploader(); + this.createAttachments(); if ( this.options.sidebar ) { this.createSidebar(); } - this.createUploader(); - this.createAttachments(); this.updateContent(); if ( ! this.options.sidebar || 'errors' === this.options.sidebar ) {