sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Language Upgrader: Re-use the automatic upgrader skin if the parent upgrader is using it.

Browse Source 
Prevents broken Ajax responses when `Language_Pack_Upgrader::async_upgrade()` gets triggered during a shiny update.

Fixes #34048.

git-svn-id: https://develop.svn.wordpress.org/trunk@34748 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Dominik Schilling (ocean90) 2015-10-01 20:24:18 +00:00
parent e0b34f44a3
commit 2f16a92362
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/wp-admin/includes/class-wp-upgrader.php
View File

@ -1867,9 +1867,14 @@ class Language_Pack_Upgrader extends WP_Upgrader {
return;
}
$skin = new Language_Pack_Upgrader_Skin( array(
'skip_header_footer' => true,
) );
// Re-use the automatic upgrader skin if the parent upgrader is using it.
if ( $upgrader && $upgrader->skin instanceof Automatic_Upgrader_Skin ) {
$skin = $upgrader->skin;
} else {
$skin = new Language_Pack_Upgrader_Skin( array(
'skip_header_footer' => true,
) );
}
$lp_upgrader = new Language_Pack_Upgrader( $skin );
$lp_upgrader->bulk_upgrade( $language_updates );
@ -3368,7 +3373,7 @@ class WP_Automatic_Updater {
// Plugins, Themes, Translations
foreach ( array( 'plugin', 'theme', 'translation' ) as $type ) {
/**
* Filter to control whether a notification email is sent to the site admin email address for
* plugin, theme, and translation updates.