sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Tests: Simplify `@covers` annotations for `WP_Error` test coverage. Also fix a typo in a test method name. 

See #42742.


git-svn-id: https://develop.svn.wordpress.org/trunk@42646 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Drew Jaynes 2018-02-03 17:37:51 +00:00
parent 86d486d67d
commit 311531a964
1 changed files with 65 additions and 105 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

170
tests/phpunit/tests/general/wpError.php
View File

@ -4,6 +4,8 @@
*
* @group general
* @group errors
*
* @coversDefaultClass WP_Error
*/
class Tests_WP_Error extends WP_UnitTestCase {
@ -23,116 +25,74 @@ class Tests_WP_Error extends WP_UnitTestCase {
$this->WP_Error = new WP_Error();
}
/**
* @covers WP_Error
*/
public function test_WP_Error_should_be_of_type_WP_Error() {
$this->assertWPError( $this->WP_Error );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_default_empty_parameters_should_add_no_errors() {
$this->assertEmpty( $this->WP_Error->errors );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_empty_code_should_add_no_code() {
$this->assertSame( '', $this->WP_Error->get_error_code() );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_empty_code_should_add_no_message() {
$this->assertSame( '', $this->WP_Error->get_error_message() );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_empty_code_should_add_no_error_data() {
$this->assertEmpty( $this->WP_Error->error_data );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_code_and_empty_message_should_add_error_with_that_code() {
$wp_error = new WP_Error( 'code' );
$this->assertSame( 'code', $wp_error->get_error_code() );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_code_and_empty_message_should_add_error_with_that_code_and_empty_message() {
$wp_error = new WP_Error( 'code' );
$this->assertSame( '', $wp_error->get_error_message( 'code' ) );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_code_and_empty_message_and_empty_data_should_add_error_but_not_associated_data() {
$wp_error = new WP_Error( 'code' );
$this->assertSame( null, $wp_error->get_error_data( 'code' ) );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_code_and_empty_message_and_non_empty_data_should_add_error_with_empty_message_and_that_stored_data() {
$wp_error = new WP_Error( 'code', '', 'data' );
$this->assertSame( 'data', $wp_error->get_error_data( 'code' ) );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_code_and_message_should_add_error_with_that_code() {
$wp_error = new WP_Error( 'code', 'message' );
$this->assertSame( 'code', $wp_error->get_error_code() );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_code_and_message_should_add_error_with_that_message() {
$wp_error = new WP_Error( 'code', 'message' );
$this->assertSame( 'message', $wp_error->get_error_message( 'code' ) );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_code_and_message_and_data_should_add_error_with_that_code() {
$wp_error = new WP_Error( 'code', 'message', 'data' );
$this->assertSame( 'code', $wp_error->get_error_code() );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_code_and_message_and_data_should_add_error_with_that_message() {
$wp_error = new WP_Error( 'code', 'message', 'data' );
$this->assertSame( 'message', $wp_error->get_error_message( 'code' ) );
}
/**
* @covers WP_Error
*/
public function test_WP_Error_with_code_and_message_and_data_should_add_error_with_that_data() {
$wp_error = new WP_Error( 'code', 'message', 'data' );
@ -140,14 +100,14 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_codes()
* @covers ::get_error_codes()
*/
public function test_get_error_codes_with_no_errors_should_return_empty_array() {
$this->assertEmpty( $this->WP_Error->get_error_codes() );
}
/**
* @covers WP_Error::get_error_codes()
* @covers ::get_error_codes()
*/
public function test_get_error_codes_with_one_error_should_return_an_array_with_only_that_code() {
$this->WP_Error->add( 'code', 'message' );
@ -156,9 +116,9 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_codes()
* @covers ::get_error_codes()
*/
public function test_get_error_codes_with_nultiple_errors_should_return_an_array_of_those_codes() {
public function test_get_error_codes_with_multiple_errors_should_return_an_array_of_those_codes() {
$this->WP_Error->add( 'code', 'message' );
$this->WP_Error->add( 'code2', 'message2' );
@ -168,14 +128,14 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_code()
* @covers ::get_error_code()
*/
public function test_get_error_code_with_no_errors_should_return_an_empty_string() {
$this->assertSame( '', $this->WP_Error->get_error_code() );
}
/**
* @covers WP_Error::get_error_code()
* @covers ::get_error_code()
*/
public function test_get_error_code_with_one_error_should_return_that_error_code() {
$this->WP_Error->add( 'code', 'message' );
@ -184,7 +144,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_code()
* @covers ::get_error_code()
*/
public function test_get_error_code_with_multiple_errors_should_return_only_the_first_error_code() {
$this->WP_Error->add( 'code', 'message' );
@ -194,14 +154,14 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_messages()
* @covers ::get_error_messages()
*/
public function test_get_error_messages_with_empty_code_and_no_errors_should_return_an_empty_array() {
$this->assertEmpty( $this->WP_Error->get_error_messages() );
}
/**
* @covers WP_Error::get_error_messages()
* @covers ::get_error_messages()
*/
public function test_get_error_messages_with_empty_code_one_error_should_return_an_array_with_that_message() {
$this->WP_Error->add( 'code', 'message' );
@ -210,7 +170,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_messages()
* @covers ::get_error_messages()
*/
public function test_get_error_messages_with_empty_code_multiple_errors_should_return_an_array_of_messages() {
$this->WP_Error->add( 'code', 'message' );
@ -220,14 +180,14 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_messages()
* @covers ::get_error_messages()
*/
public function test_get_error_messages_with_an_invalid_code_should_return_an_empty_array() {
$this->assertEmpty( $this->WP_Error->get_error_messages( 'code' ) );
}
/**
* @covers WP_Error::get_error_messages()
* @covers ::get_error_messages()
*/
public function test_get_error_messages_with_one_error_should_return_an_array_with_that_message() {
$this->WP_Error->add( 'code', 'message' );
@ -236,7 +196,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_messages()
* @covers ::get_error_messages()
*/
public function test_get_error_messages_with_multiple_errors_same_code_should_return_an_array_with_all_messages() {
$this->WP_Error->add( 'code', 'message' );
@ -246,14 +206,14 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_message()
* @covers ::get_error_message()
*/
public function test_get_error_message_with_empty_code_and_no_errors_should_return_an_empty_string() {
$this->assertSame( '', $this->WP_Error->get_error_message() );
}
/**
* @covers WP_Error::get_error_message()
* @covers ::get_error_message()
*/
public function test_get_error_message_with_empty_code_and_one_error_should_return_that_message() {
$this->WP_Error->add( 'code', 'message' );
@ -262,7 +222,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_message()
* @covers ::get_error_message()
*/
public function test_get_error_message_with_empty_code_and_multiple_errors_should_return_the_first_message() {
$this->WP_Error->add( 'code', 'message' );
@ -272,7 +232,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_message()
* @covers ::get_error_message()
*/
public function test_get_error_message_with_empty_code_and_multiple_errors_multiple_codes_should_return_the_first_message() {
$this->WP_Error->add( 'code', 'message' );
@ -283,14 +243,14 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_message()
* @covers ::get_error_message()
*/
public function test_get_error_message_with_invalid_code_and_no_errors_should_return_empty_string() {
$this->assertSame( '', $this->WP_Error->get_error_message( 'invalid' ) );
}
/**
* @covers WP_Error::get_error_message()
* @covers ::get_error_message()
*/
public function test_get_error_message_with_invalid_code_and_one_error_should_return_an_empty_string() {
$this->WP_Error->add( 'code', 'message' );
@ -299,7 +259,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_message()
* @covers ::get_error_message()
*/
public function test_get_error_message_with_invalid_code_and_multiple_errors_should_return_an_empty_string() {
$this->WP_Error->add( 'code', 'message' );
@ -309,14 +269,14 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_data()
* @covers ::get_error_data()
*/
public function test_get_error_data_with_empty_code_and_no_errors_should_evaluate_as_null() {
$this->assertSame( null, $this->WP_Error->get_error_data() );
}
/**
* @covers WP_Error::get_error_data()
* @covers ::get_error_data()
*/
public function test_get_error_data_with_empty_code_one_error_no_data_should_evaluate_as_null() {
$this->WP_Error->add( 'code', 'message' );
@ -325,7 +285,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_data()
* @covers ::get_error_data()
*/
public function test_get_error_data_with_empty_code_multiple_errors_no_data_should_evaluate_as_null() {
$this->WP_Error->add( 'code', 'message' );
@ -335,7 +295,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_data()
* @covers ::get_error_data()
*/
public function test_get_error_data_with_empty_code_and_one_error_with_data_should_return_that_data() {
$expected = array( 'data-key' => 'data-value' );
@ -345,7 +305,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_data()
* @covers ::get_error_data()
*/
public function test_get_error_data_with_empty_code_and_multiple_errors_different_codes_should_return_the_last_data_of_the_first_code() {
$expected = array( 'data-key' => 'data-value' );
@ -356,7 +316,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_data()
* @covers ::get_error_data()
*/
public function test_get_error_data_with_empty_code_and_multiple_errors_same_code_should_return_the_last_data_of_the_first_code() {
$this->WP_Error->add( 'code', 'message', 'data' );
@ -367,14 +327,14 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_data()
* @covers ::get_error_data()
*/
public function test_get_error_data_with_code_and_no_errors_should_evaluate_as_null() {
$this->assertSame( null, $this->WP_Error->get_error_data( 'code' ) );
}
/**
* @covers WP_Error::get_error_data()
* @covers ::get_error_data()
*/
public function test_get_error_data_with_code_and_one_error_with_no_data_should_evaluate_as_null() {
$this->WP_Error->add( 'code', 'message' );
@ -383,7 +343,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_data()
* @covers ::get_error_data()
*/
public function test_get_error_data_with_code_and_one_error_with_data_should_return_that_data() {
$expected = array( 'data-key' => 'data-value' );
@ -393,7 +353,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_data()
* @covers ::get_error_data()
*/
public function test_get_error_data_with_code_and_multiple_errors_different_codes_should_return_the_last_stored_data_of_the_code() {
$expected = array( 'data3' );
@ -405,7 +365,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::get_error_data()
* @covers ::get_error_data()
*/
public function test_get_error_data_with_code_and_multiple_errors_same_code_should_return_the_last_stored_data() {
$this->WP_Error->add( 'code', 'message', 'data' );
@ -416,7 +376,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_empty_code_empty_message_empty_data_should_add_empty_key_to_errors_array() {
$this->WP_Error->add( '', '', 'data' );
@ -425,7 +385,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_empty_code_empty_message_empty_data_should_add_empty_message_to_errors_array_under_empty_key() {
$this->WP_Error->add( '', '', 'data' );
@ -434,7 +394,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_empty_code_empty_message_empty_data_should_not_alter_data() {
$this->WP_Error->add( '', '', '' );
@ -443,7 +403,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_empty_code_empty_message_non_empty_data_should_store_data_under_an_empty_code_key() {
$this->WP_Error->add( '', '', 'data' );
@ -452,7 +412,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_code_empty_message_empty_data_should_add_error_with_code() {
$this->WP_Error->add( 'code', '' );
@ -461,7 +421,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_code_empty_message_empty_data_should_add_error_with_empty_message() {
$this->WP_Error->add( 'code', '' );
@ -470,7 +430,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_code_empty_message_empty_data_should_not_add_error_data() {
$this->WP_Error->add( 'code', '' );
@ -479,7 +439,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_code_and_message_and_empty_data_should_should_add_error_with_that_message() {
$this->WP_Error->add( 'code', 'message' );
@ -488,7 +448,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_code_and_message_and_empty_data_should_not_alter_stored_data() {
$this->WP_Error->add( 'code', 'message' );
@ -497,7 +457,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_code_and_empty_message_and_data_should_add_error_with_that_code() {
$this->WP_Error->add( 'code', '', 'data' );
@ -506,7 +466,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_code_and_empty_message_and_data_should_store_that_data() {
$this->WP_Error->add( 'code', '', 'data' );
@ -515,7 +475,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_code_and_message_and_data_should_add_an_error_with_that_code() {
$this->WP_Error->add( 'code', 'message', 'data' );
@ -524,7 +484,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_code_and_message_and_data_should_add_an_error_with_that_message() {
$this->WP_Error->add( 'code', 'message', 'data' );
@ -533,7 +493,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_with_code_and_message_and_data_should_store_that_data() {
$this->WP_Error->add( 'code', 'message', 'data' );
@ -542,7 +502,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_multiple_times_with_the_same_code_should_add_additional_messages_for_that_code() {
$this->WP_Error->add( 'code', 'message' );
@ -554,7 +514,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add()
* @covers ::add()
*/
public function test_add_multiple_times_with_the_same_code_and_different_data_should_store_only_the_last_added_data() {
$this->WP_Error->add( 'code', 'message', 'data-bar' );
@ -564,7 +524,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add_data()
* @covers ::add_data()
*/
public function test_add_data_with_empty_data_empty_code_should_create_orphaned_data_with_no_error() {
$this->WP_Error->add_data( '' );
@ -573,7 +533,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add_data()
* @covers ::add_data()
*/
public function test_add_data_with_empty_data_empty_code_no_errors_should_create_data_under_an_empty_code_key() {
$this->WP_Error->add_data( '' );
@ -582,7 +542,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add_data()
* @covers ::add_data()
*/
public function test_add_data_with_data_empty_code_and_one_error_should_store_the_data_under_that_code() {
$this->WP_Error->add( 'code', 'message' );
@ -592,7 +552,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add_data()
* @covers ::add_data()
*/
public function test_add_data_with_data_empty_code_and_multiple_errors_with_different_codes_should_store_it_under_the_first_code() {
$this->WP_Error->add( 'code', 'message' );
@ -604,7 +564,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add_data()
* @covers ::add_data()
*/
public function test_add_data_with_data_empty_code_and_multiple_errors_with_same_code_should_store_it_under_the_first_code() {
$this->WP_Error->add( 'code', 'message' );
@ -617,7 +577,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add_data()
* @covers ::add_data()
*/
public function test_add_data_with_data_and_code_and_no_errors_should_create_orphaned_data_with_no_error() {
$this->WP_Error->add_data( 'data', 'code' );
@ -626,7 +586,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add_data()
* @covers ::add_data()
*/
public function test_add_data_with_data_and_code_no_errors_should_create_data_under_that_code_key() {
$this->WP_Error->add_data( 'data', 'code' );
@ -635,7 +595,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add_data()
* @covers ::add_data()
*/
public function test_add_data_with_data_and_code_one_error_different_code_should_create_orphaned_data_with_no_error() {
$this->WP_Error->add( 'code', 'message' );
@ -646,7 +606,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add_data()
* @covers ::add_data()
*/
public function test_add_data_with_data_and_code_one_error_different_code_should_create_data_under_that_code_key() {
$this->WP_Error->add( 'code', 'message' );
@ -657,7 +617,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::add_data()
* @covers ::add_data()
*/
public function test_add_data_with_data_and_code_should_add_data() {
$this->WP_Error->add( 'code', 'message' );
@ -668,7 +628,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::remove()
* @covers ::remove()
*/
public function test_remove_with_no_errors_should_affect_nothing() {
$before = $this->WP_Error->errors;
@ -681,7 +641,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::remove()
* @covers ::remove()
*/
public function test_remove_empty_code_no_errors_should_affect_nothing() {
$before = $this->WP_Error->errors;
@ -694,7 +654,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::remove()
* @covers ::remove()
*/
public function test_remove_empty_code_and_one_error_with_empty_string_code_should_remove_error() {
$before = $this->WP_Error->errors;
@ -709,7 +669,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::remove()
* @covers ::remove()
*/
public function test_remove_empty_code_and_one_error_with_empty_string_code_should_remove_error_data() {
$this->WP_Error->add( '', 'message', 'data' );
@ -722,7 +682,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::remove()
* @covers ::remove()
*/
public function test_remove_should_remove_the_error_with_the_given_code() {
$this->WP_Error->add( 'code', 'message' );
@ -733,7 +693,7 @@ class Tests_WP_Error extends WP_UnitTestCase {
}
/**
* @covers WP_Error::remove()
* @covers ::remove()
*/
public function test_remove_should_remove_the_error_data_associated_with_the_given_code() {
$this->WP_Error->add( 'code', 'message', 'data' );