Schema: Increase the length of `wp_options.option_name`.
It's pretty easy to run over the `option_name` length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from `VARCHAR(64)` to `VARCHAR(191)` significantly reduces the risk of this occurring. Because `option_name` has a `UNIQUE` index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer. Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento. Fixes #13310. git-svn-id: https://develop.svn.wordpress.org/trunk@34030 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
parent
4796e96ebe
commit
32b8ff1b14
|
@ -135,7 +135,7 @@ CREATE TABLE $wpdb->links (
|
||||||
) $charset_collate;
|
) $charset_collate;
|
||||||
CREATE TABLE $wpdb->options (
|
CREATE TABLE $wpdb->options (
|
||||||
option_id bigint(20) unsigned NOT NULL auto_increment,
|
option_id bigint(20) unsigned NOT NULL auto_increment,
|
||||||
option_name varchar(64) NOT NULL default '',
|
option_name varchar(191) NOT NULL default '',
|
||||||
option_value longtext NOT NULL,
|
option_value longtext NOT NULL,
|
||||||
autoload varchar(20) NOT NULL default 'yes',
|
autoload varchar(20) NOT NULL default 'yes',
|
||||||
PRIMARY KEY (option_id),
|
PRIMARY KEY (option_id),
|
||||||
|
|
|
@ -538,6 +538,9 @@ function upgrade_all() {
|
||||||
if ( $wp_current_db_version < 33056 )
|
if ( $wp_current_db_version < 33056 )
|
||||||
upgrade_431();
|
upgrade_431();
|
||||||
|
|
||||||
|
if ( $wp_current_db_version < 34030 )
|
||||||
|
upgrade_440();
|
||||||
|
|
||||||
maybe_disable_link_manager();
|
maybe_disable_link_manager();
|
||||||
|
|
||||||
maybe_disable_automattic_widgets();
|
maybe_disable_automattic_widgets();
|
||||||
|
@ -1595,6 +1598,22 @@ function upgrade_431() {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Executes changes made in WordPress 4.4.0.
|
||||||
|
*
|
||||||
|
* @since 4.4.0
|
||||||
|
*
|
||||||
|
* @global int $wp_current_db_version Current version.
|
||||||
|
* @global wpdb $wpdb WordPress database abstraction object.
|
||||||
|
*/
|
||||||
|
function upgrade_440() {
|
||||||
|
global $wp_current_db_version, $wpdb;
|
||||||
|
|
||||||
|
if ( $wp_current_db_version < 34030 ) {
|
||||||
|
$wpdb->query( "ALTER TABLE {$wpdb->options} MODIFY option_name VARCHAR(191)" );
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Executes network-level upgrade routines.
|
* Executes network-level upgrade routines.
|
||||||
*
|
*
|
||||||
|
|
|
@ -11,7 +11,7 @@ $wp_version = '4.4-alpha-33636-src';
|
||||||
*
|
*
|
||||||
* @global int $wp_db_version
|
* @global int $wp_db_version
|
||||||
*/
|
*/
|
||||||
$wp_db_version = 33056;
|
$wp_db_version = 34030;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Holds the TinyMCE version
|
* Holds the TinyMCE version
|
||||||
|
|
Loading…
Reference in New Issue