diff --git a/src/wp-includes/rest-api.php b/src/wp-includes/rest-api.php index e0807e7696..d0066ff0fe 100644 --- a/src/wp-includes/rest-api.php +++ b/src/wp-includes/rest-api.php @@ -17,7 +17,10 @@ define( 'REST_API_VERSION', '2.0' ); /** * Registers a REST API route. * + * Note: Do not use before the {@see 'rest_api_init'} hook. + * * @since 4.4.0 + * @since 5.1.0 Added a _doing_it_wrong() notice when not called on or after the rest_api_init hook. * * @param string $namespace The first URL segment after core prefix. Should be unique to your package/plugin. * @param string $route The base URL for route you are adding. @@ -41,6 +44,10 @@ function register_rest_route( $namespace, $route, $args = array(), $override = f return false; } + if ( ! did_action( 'rest_api_init' ) ) { + _doing_it_wrong( 'register_rest_route', __( 'REST API routes must be registered on the rest_api_init action.' ), '5.1.0' ); + } + if ( isset( $args['args'] ) ) { $common_args = $args['args']; unset( $args['args'] ); diff --git a/tests/phpunit/tests/rest-api.php b/tests/phpunit/tests/rest-api.php index dc94c7b6dd..7e72708d43 100644 --- a/tests/phpunit/tests/rest-api.php +++ b/tests/phpunit/tests/rest-api.php @@ -14,9 +14,11 @@ require_once ABSPATH . WPINC . '/rest-api.php'; */ class Tests_REST_API extends WP_UnitTestCase { public function setUp() { + parent::setUp(); + // Override the normal server with our spying server. $GLOBALS['wp_rest_server'] = new Spy_REST_Server(); - parent::setUp(); + do_action( 'rest_api_init', $GLOBALS['wp_rest_server'] ); } public function tearDown() {