sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

REST API: Prevent PHP warning when metadata schema is missing properties.

Browse Source 
This switches to the new `rest_default_additional_properties_to_false()` function which doesn't have this issue and deprecates the `WP_REST_Meta_Fields::default_additional_properties_to_false()` method.

Props austin880625.
Fixes #51389.


git-svn-id: https://develop.svn.wordpress.org/trunk@49308 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Timothy Jacobs 2020-10-25 20:28:50 +00:00
parent 9eed4bc352
commit 3646dd2e9f
1 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php
View File

@ -466,7 +466,7 @@ abstract class WP_REST_Meta_Fields {
$rest_args['schema']['default'] = static::get_empty_value_for_type( $type ); $rest_args['schema']['default'] = static::get_empty_value_for_type( $type );
} }
$rest_args['schema'] = $this->default_additional_properties_to_false( $rest_args['schema'] ); $rest_args['schema'] = rest_default_additional_properties_to_false( $rest_args['schema'] );
if ( ! in_array( $type, array( 'string', 'boolean', 'integer', 'number', 'array', 'object' ), true ) ) { if ( ! in_array( $type, array( 'string', 'boolean', 'integer', 'number', 'array', 'object' ), true ) ) {
continue; continue;
@ -571,27 +571,15 @@ abstract class WP_REST_Meta_Fields {
* default. * default.
* *
* @since 5.3.0 * @since 5.3.0
* @deprecated 5.6.0 Use rest_default_additional_properties_to_false() instead.
* *
* @param array $schema The schema array. * @param array $schema The schema array.
* @return array * @return array
*/ */
protected function default_additional_properties_to_false( $schema ) { protected function default_additional_properties_to_false( $schema ) {
switch ( $schema['type'] ) { _deprecated_function( __METHOD__, '5.6.0', 'rest_default_additional_properties_to_false()' );
case 'object':
foreach ( $schema['properties'] as $key => $child_schema ) {
$schema['properties'][ $key ] = $this->default_additional_properties_to_false( $child_schema );
}
if ( ! isset( $schema['additionalProperties'] ) ) { return rest_default_additional_properties_to_false( $schema );
$schema['additionalProperties'] = false;
}
break;
case 'array':
$schema['items'] = $this->default_additional_properties_to_false( $schema['items'] );
break;
}
return $schema;
} }
/** /**