sergiotarxz/Wordpress
sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Menus: Ensure that category menus with special characters can be updated.

Browse Source 
Slashes and HTML encoding could cause some menus not to be updated.

Fixes #48011.

Props zaheerahmad, achyuthajoy, desrosj, pento, SergeyBiryukov, donmhico, audrasjb, birgire, mikeschroder.



git-svn-id: https://develop.svn.wordpress.org/trunk@48416 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jake Spurlock 2020-07-10 05:58:49 +00:00
parent 80e2a20c53
commit 3667d18943
2 changed files with 46 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-includes/nav-menu.php
View File

@ -492,7 +492,7 @@ function wp_update_nav_menu_item( $menu_id = 0, $menu_item_db_id = 0, $menu_item
}
}
if ( $args['menu-item-title'] == $original_title ) {
if ( wp_unslash( $args['menu-item-title'] ) == wp_specialchars_decode( $original_title ) ) {
$args['menu-item-title'] = '';
}

45
tests/phpunit/tests/post/nav-menu.php
View File

@ -956,4 +956,49 @@ class Test_Nav_Menus extends WP_UnitTestCase {
);
}
/**
* Tests `wp_update_nav_menu_item()` with special characters in a category name.
*
* When inserting a category as a nav item, the `$args['menu-item-title']` should
* always be empty as it should get the title from the category object itself.
*
* @ticket 48011
*/
function test_wp_update_nav_menu_item_with_special_character_in_categories() {
$category_name = 'Test Cat - \"Pre-Slashed\" Cat Name & >';
$cat = self::factory()->category->create_and_get(
array(
'name' => $category_name,
)
);
add_action( 'wp_update_nav_menu_item', array( $this, 'callback_wp_update_nav_menu_item_48011' ), 10, 3 );
wp_update_nav_menu_item(
$this->menu_id,
0,
array(
'menu-item-type' => 'taxonomy',
'menu-item-object' => 'category',
'menu-item-object-id' => $cat->term_id,
'menu-item-status' => 'publish',
/**
* Interestingly enough, if we use `$cat->name` for the menu item title,
* we won't be able to replicate the bug because it's in htmlentities form.
*/
'menu-item-title' => $category_name,
)
);
}
/**
* Callback for the `wp_update_nav_menu_item` action.
*
* @since 5.5.0
*/
function callback_wp_update_nav_menu_item_48011( $menu_id, $menu_item_db_id, $args ) {
$this->assertEmpty( $args['menu-item-title'] );
}
}