sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Taxonomy: Improve backward compatibility on the wp-admin/term.php page.

Browse Source 
Specifically, run `do_action( 'edit-tags.php' );` on this new term edit page introduced in [36308]. Changes the GET param back to `tag_ID` and properly sets the screen base in `WP_Screen`.

See #34988.

git-svn-id: https://develop.svn.wordpress.org/trunk@36874 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Pascal Birchler 2016-03-07 12:55:04 +00:00
parent afdf1c9ec1
commit 3a51ff4d2e
7 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-admin/admin.php
View File

@ -355,6 +355,8 @@ if ( isset($plugin_page) ) {
do_action( 'load-categories.php' );
elseif ( $taxnow == 'link_category' )
do_action( 'load-edit-link-categories.php' );
} elseif( 'term.php' === $pagenow ) {
do_action( 'edit-tags.php' );
}
}

2
src/wp-admin/includes/class-wp-screen.php
View File

@ -304,6 +304,7 @@ final class WP_Screen {
}
break;
case 'edit-tags' :
case 'term' :
if ( null === $post_type && is_object_in_taxonomy( 'post', $taxonomy ? $taxonomy : 'post_tag' ) )
$post_type = 'post';
break;
@ -322,6 +323,7 @@ final class WP_Screen {
$id .= '-' . $post_type;
break;
case 'edit-tags' :
case 'term' :
if ( null === $taxonomy )
$taxonomy = 'post_tag';
// The edit-tags ID does not contain the post type. Look for it in the request.

6
src/wp-admin/term.php
View File

@ -10,7 +10,7 @@
/** WordPress Administration Bootstrap */
require_once( dirname( __FILE__ ) . '/admin.php' );
if ( empty( $_REQUEST['term_id'] ) ) {
if ( empty( $_REQUEST['tag_ID'] ) ) {
$sendback = admin_url( 'edit-tags.php' );
if ( ! empty( $taxnow ) ) {
$sendback = add_query_arg( array( 'taxonomy' => $taxnow ), $sendback );
@ -19,8 +19,8 @@ if ( empty( $_REQUEST['term_id'] ) ) {
exit;
}
$term_id = absint( $_REQUEST['term_id'] );
$tag = get_term( $term_id, $taxnow, OBJECT, 'edit' );
$term_id = absint( $_REQUEST['tag_ID'] );
$tag = get_term( $term_id, '', OBJECT, 'edit' );
if ( ! $tag instanceof WP_Term ) {
wp_die( __( 'You attempted to edit an item that doesn’t exist. Perhaps it was deleted?' ) );

2
src/wp-includes/admin-bar.php
View File

@ -573,7 +573,7 @@ function wp_admin_bar_edit_menu( $wp_admin_bar ) {
'href' => get_permalink( $post->ID )
) );
}
} elseif ( 'edit-tags' == $current_screen->base
} elseif ( 'term' == $current_screen->base
&& isset( $tag ) && is_object( $tag ) && ! is_wp_error( $tag )
&& ( $tax = get_taxonomy( $tag->taxonomy ) )
&& $tax->public )

2
src/wp-includes/link-template.php
View File

@ -928,7 +928,7 @@ function get_edit_term_link( $term_id, $taxonomy = '', $object_type = '' ) {
$args = array(
'taxonomy' => $taxonomy,
'term_id' => $term->term_id,
'tag_ID' => $term->term_id,
);
if ( $object_type ) {

2
tests/phpunit/tests/post.php
View File

@ -991,7 +991,7 @@ class Tests_Post extends WP_UnitTestCase {
$term = reset( $terms );
foreach ( $matches[1] as $url ) {
$this->assertContains( 'term_id=' . $term->term_id, $url );
$this->assertContains( 'tag_ID=' . $term->term_id, $url );
$this->assertContains( 'post_type=new_post_type', $url );
}
}

2
tests/phpunit/tests/term/getEditTermLink.php
View File

@ -17,7 +17,7 @@ class Tests_Term_GetEditTermLink extends WP_UnitTestCase {
) );
$actual = get_edit_term_link( $term1, 'wptests_tax' );
$expected = 'http://' . WP_TESTS_DOMAIN . '/wp-admin/term.php?taxonomy=wptests_tax&term_id=' . $term1 . '&post_type=post';
$expected = 'http://' . WP_TESTS_DOMAIN . '/wp-admin/term.php?taxonomy=wptests_tax&tag_ID=' . $term1 . '&post_type=post';
$this->assertEquals( $expected, $actual );
}