From 3bfa4606c7dbc742b761d929ff35048374decb4b Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Fri, 25 Sep 2020 01:29:51 +0000 Subject: [PATCH] Tests: Check if image sizes were successfully retrieved in some REST API attachments controller tests. This outputs a proper message in case of failure, instead of an obscure PHP error further in the test. Props TimothyBlynJacobs. See #50913, #51393. git-svn-id: https://develop.svn.wordpress.org/trunk@49044 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/rest-api/rest-attachments-controller.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/phpunit/tests/rest-api/rest-attachments-controller.php b/tests/phpunit/tests/rest-api/rest-attachments-controller.php index 571337f6d4..ef2cc85189 100644 --- a/tests/phpunit/tests/rest-api/rest-attachments-controller.php +++ b/tests/phpunit/tests/rest-api/rest-attachments-controller.php @@ -604,6 +604,7 @@ class WP_Test_REST_Attachments_Controller extends WP_Test_REST_Post_Type_Control $original_image_src = wp_get_attachment_image_src( $attachment_id, 'full' ); remove_image_size( 'rest-api-test' ); + $this->assertNotEmpty( $data['media_details']['sizes'] ); $this->assertSame( $image_src[0], $data['media_details']['sizes']['rest-api-test']['source_url'] ); $this->assertSame( 'image/jpeg', $data['media_details']['sizes']['rest-api-test']['mime_type'] ); $this->assertSame( $original_image_src[0], $data['media_details']['sizes']['full']['source_url'] ); @@ -632,6 +633,7 @@ class WP_Test_REST_Attachments_Controller extends WP_Test_REST_Post_Type_Control remove_filter( 'wp_get_attachment_image_src', '__return_false' ); remove_image_size( 'rest-api-test' ); + $this->assertNotEmpty( $data['media_details']['sizes'] ); $this->assertFalse( isset( $data['media_details']['sizes']['rest-api-test']['source_url'] ) ); }