List tables: Better accessibility and design for the comments bubble.
It is now plain text in the comments list table's "In Response To" column, where it was visually a bit confusing to have the bubble. For other list tables, it now shows a little notification bubble with the number of pending comments. The bubble and notification become plain text in the responsive list table view. It also shows no bubble when there are no comments at all, reducing some of the visual noise. props picard102, afercia, karinchristen. fixes #32152. git-svn-id: https://develop.svn.wordpress.org/trunk@33155 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Helen Hou-Sandi
parent
68cd0bc870
commit
3e0f839eca
|
|
@ -1,77 +1,124 @@
|
|||
/* List table styles */
|
||||
.post-com-count-wrapper {
|
||||
min-width: 22px;
|
||||
}
|
||||
|
||||
.post-com-count {
|
||||
background: none;
|
||||
height: 1.3em;
|
||||
line-height: 1.1em;
|
||||
.response-links {
|
||||
display: block;
|
||||
text-decoration: none;
|
||||
padding: 0 0 6px;
|
||||
cursor: pointer;
|
||||
background-position: center -80px;
|
||||
background-repeat: no-repeat;
|
||||
color: #fff;
|
||||
margin-bottom: 1em;
|
||||
}
|
||||
|
||||
.post-com-count:after { /* draw bubble connector using CSS! */
|
||||
content: "";
|
||||
.response-links a {
|
||||
display: block;
|
||||
width: 0;
|
||||
height: 0;
|
||||
margin-left: 8px;
|
||||
border-top: 5px solid #b4b9be;
|
||||
border-right: 5px solid transparent;
|
||||
}
|
||||
|
||||
.post-com-count span {
|
||||
font-size: 11px;
|
||||
.response-links a.comments-edit-item-link {
|
||||
font-weight: 600;
|
||||
height: 1.4em;
|
||||
line-height: 1.4em;
|
||||
min-width: 0.7em;
|
||||
padding: 0 6px;
|
||||
}
|
||||
|
||||
.response-links a.comments-view-item-link {
|
||||
font-size: 12px;
|
||||
}
|
||||
|
||||
.column-response .post-com-count .screen-reader-text {
|
||||
position: static;
|
||||
width: auto;
|
||||
height: auto;
|
||||
margin: 0;
|
||||
}
|
||||
|
||||
.column-response .post-com-count [aria-hidden="true"] {
|
||||
display: none;
|
||||
}
|
||||
|
||||
.post-com-count-wrapper strong {
|
||||
font-weight: 400;
|
||||
}
|
||||
|
||||
.column-response .post-com-count.post-com-count-pending {
|
||||
color: #bb2a2a;
|
||||
}
|
||||
|
||||
.comments-view-item-link {
|
||||
display: inline-block;
|
||||
-webkit-border-radius: 5px;
|
||||
border-radius: 5px;
|
||||
background-color: #b4b9be;
|
||||
color: #fff;
|
||||
clear: both;
|
||||
}
|
||||
|
||||
.post-com-count:hover {
|
||||
background-position: center -3px;
|
||||
.column-comments .post-com-count-wrapper {
|
||||
white-space: nowrap;
|
||||
word-wrap: normal;
|
||||
}
|
||||
|
||||
.post-com-count:hover span {
|
||||
background-color: #00a0d2;
|
||||
}
|
||||
|
||||
.post-com-count:hover:after {
|
||||
border-top: 5px solid #00a0d2;
|
||||
}
|
||||
|
||||
strong .post-com-count {
|
||||
background-position: center -55px;
|
||||
}
|
||||
|
||||
strong .post-com-count span {
|
||||
background-color: #0073aa;
|
||||
}
|
||||
|
||||
strong .post-com-count:after {
|
||||
border-top: 5px solid #0073aa;
|
||||
/* comments bubble common */
|
||||
.column-comments .post-com-count {
|
||||
display: inline-block;
|
||||
vertical-align: top;
|
||||
}
|
||||
|
||||
.column-response .post-com-count {
|
||||
float: left;
|
||||
margin-right: 5px;
|
||||
display: block;
|
||||
}
|
||||
|
||||
/* comments bubble approved */
|
||||
.column-comments .post-com-count-no-comments,
|
||||
.column-comments .post-com-count-approved {
|
||||
margin-top: 5px;
|
||||
}
|
||||
|
||||
.column-comments .comment-count-no-comments,
|
||||
.column-comments .comment-count-approved {
|
||||
-webkit-box-sizing: border-box;
|
||||
-moz-box-sizing: border-box;
|
||||
box-sizing: border-box;
|
||||
display: block;
|
||||
padding: 0 8px;
|
||||
min-width: 24px;
|
||||
height: 2em;
|
||||
-webkit-border-radius: 5px;
|
||||
border-radius: 5px;
|
||||
background-color: #72777c;
|
||||
color: #fff;
|
||||
font-size: 11px;
|
||||
line-height: 21px;
|
||||
text-align: center;
|
||||
}
|
||||
|
||||
.response-links {
|
||||
float: left;
|
||||
.ie8 .column-comments .comment-count-no-comments,
|
||||
.ie8 .column-comments .comment-count-approved {
|
||||
min-width: 0;
|
||||
}
|
||||
|
||||
.column-comments .post-com-count-no-comments:after,
|
||||
.column-comments .post-com-count-approved:after {
|
||||
content: "";
|
||||
display: block;
|
||||
margin-left: 8px;
|
||||
width: 0;
|
||||
height: 0;
|
||||
border-top: 5px solid #72777c;
|
||||
border-right: 5px solid transparent;
|
||||
}
|
||||
|
||||
.column-comments .post-com-count-approved:hover .comment-count-approved,
|
||||
.column-comments .post-com-count-approved:focus .comment-count-approved {
|
||||
background: #0073aa;
|
||||
}
|
||||
|
||||
.column-comments .post-com-count-approved:hover:after,
|
||||
.column-comments .post-com-count-approved:focus:after {
|
||||
border-top-color: #0073aa;
|
||||
}
|
||||
|
||||
/* comments bubble pending */
|
||||
.column-comments .post-com-count-pending {
|
||||
position: relative;
|
||||
left: -3px;
|
||||
padding: 0 5px;
|
||||
min-width: 7px;
|
||||
height: 17px;
|
||||
border: 2px solid #fff;
|
||||
-webkit-border-radius: 11px;
|
||||
border-radius: 11px;
|
||||
background: #ca4a1f;
|
||||
color: #fff;
|
||||
font-size: 9px;
|
||||
line-height: 17px;
|
||||
text-align: center;
|
||||
}
|
||||
|
||||
/* comments */
|
||||
|
|
@ -283,7 +330,7 @@ table.fixed {
|
|||
}
|
||||
|
||||
.fixed .column-comments {
|
||||
width: 4em;
|
||||
width: 5.5em;
|
||||
padding: 8px 0;
|
||||
text-align: left;
|
||||
}
|
||||
|
|
@ -292,9 +339,6 @@ table.fixed {
|
|||
padding-left: 3px;
|
||||
}
|
||||
|
||||
.fixed .column-comments a {
|
||||
float: left;
|
||||
}
|
||||
|
||||
td.column-title strong,
|
||||
td.plugin-title strong {
|
||||
|
|
@ -1452,14 +1496,6 @@ tr.active + tr.plugin-update-tr:not(.updated) .plugin-update .update-message {
|
|||
}
|
||||
}
|
||||
|
||||
@media screen and ( max-width: 782px ) {
|
||||
.plugin-card {
|
||||
margin-left: 0;
|
||||
margin-right: 0;
|
||||
width: 100%;
|
||||
}
|
||||
}
|
||||
|
||||
.plugin-card-top {
|
||||
position: relative;
|
||||
padding: 20px 20px 10px;
|
||||
|
|
@ -1815,6 +1851,56 @@ div.action-links,
|
|||
box-shadow: inset 0 -1px 0 rgba(0, 0, 0, 0.1);
|
||||
}
|
||||
|
||||
/* Show comment bubble as text instead */
|
||||
.post-com-count .screen-reader-text {
|
||||
position: static;
|
||||
width: auto;
|
||||
height: auto;
|
||||
margin: 0;
|
||||
}
|
||||
|
||||
.column-comments .post-com-count-no-comments:after,
|
||||
.column-comments .post-com-count-approved:after {
|
||||
content: none;
|
||||
}
|
||||
|
||||
.column-comments .post-com-count [aria-hidden="true"] {
|
||||
display: none;
|
||||
}
|
||||
|
||||
.column-comments .post-com-count-wrapper {
|
||||
white-space: normal;
|
||||
}
|
||||
|
||||
.column-comments .post-com-count-wrapper > a {
|
||||
display: block;
|
||||
}
|
||||
|
||||
.column-comments .post-com-count-no-comments,
|
||||
.column-comments .post-com-count-approved {
|
||||
margin-top: 0;
|
||||
margin-right: 0.5em;
|
||||
}
|
||||
|
||||
.column-comments .post-com-count-pending {
|
||||
position: static;
|
||||
height: auto;
|
||||
min-width: 0;
|
||||
padding: 0;
|
||||
border: none;
|
||||
-webkit-border-radius: 0;
|
||||
border-radius: 0;
|
||||
background: none;
|
||||
color: #bb2a2a;
|
||||
font-size: inherit;
|
||||
line-height: inherit;
|
||||
text-align: left;
|
||||
}
|
||||
|
||||
.column-comments .post-com-count-pending:hover {
|
||||
color: #dc3232;
|
||||
}
|
||||
|
||||
.widefat thead .check-column, .widefat tfoot .check-column {
|
||||
padding: 10px 0 10px;
|
||||
}
|
||||
|
|
@ -2020,4 +2106,10 @@ div.action-links,
|
|||
-webkit-box-shadow: inset 0 -1px 0 rgba(0,0,0,0.1);
|
||||
box-shadow: inset 0 -1px 0 rgba(0,0,0,0.1);
|
||||
}
|
||||
|
||||
.plugin-card {
|
||||
margin-left: 0;
|
||||
margin-right: 0;
|
||||
width: 100%;
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -678,21 +678,23 @@ class WP_Comments_List_Table extends WP_List_Table {
|
|||
}
|
||||
|
||||
if ( current_user_can( 'edit_post', $post->ID ) ) {
|
||||
$post_link = "<a href='" . get_edit_post_link( $post->ID ) . "'>";
|
||||
$post_link = "<a href='" . get_edit_post_link( $post->ID ) . "' class='comments-edit-item-link'>";
|
||||
$post_link .= esc_html( get_the_title( $post->ID ) ) . '</a>';
|
||||
} else {
|
||||
$post_link = esc_html( get_the_title( $post->ID ) );
|
||||
}
|
||||
|
||||
echo '<div class="response-links"><span class="post-com-count-wrapper">';
|
||||
echo $post_link . '<br />';
|
||||
echo '<div class="response-links">';
|
||||
echo $post_link;
|
||||
$post_type_object = get_post_type_object( $post->post_type );
|
||||
echo "<a href='" . get_permalink( $post->ID ) . "' class='comments-view-item-link'>" . $post_type_object->labels->view_item . '</a>';
|
||||
if ( 'attachment' == $post->post_type && ( $thumb = wp_get_attachment_image( $post->ID, array( 80, 60 ), true ) ) ) {
|
||||
echo $thumb;
|
||||
}
|
||||
echo '</div>';
|
||||
echo '<span class="post-com-count-wrapper">';
|
||||
$this->comments_bubble( $post->ID, $pending_comments );
|
||||
echo '</span> ';
|
||||
$post_type_object = get_post_type_object( $post->post_type );
|
||||
echo "<a href='" . get_permalink( $post->ID ) . "'>" . $post_type_object->labels->view_item . '</a>';
|
||||
echo '</div>';
|
||||
if ( 'attachment' == $post->post_type && ( $thumb = wp_get_attachment_image( $post->ID, array( 80, 60 ), true ) ) )
|
||||
echo $thumb;
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
|||
|
|
@ -614,15 +614,41 @@ class WP_List_Table {
|
|||
* @param int $pending_comments Number of pending comments.
|
||||
*/
|
||||
protected function comments_bubble( $post_id, $pending_comments ) {
|
||||
$pending_phrase = sprintf( __( '%s pending' ), number_format( $pending_comments ) );
|
||||
$approved_comments = get_comments_number();
|
||||
|
||||
if ( $pending_comments )
|
||||
echo '<strong>';
|
||||
$approved_comments_number = number_format_i18n( $approved_comments );
|
||||
$pending_comments_number = number_format_i18n( $pending_comments );
|
||||
|
||||
echo "<a href='" . esc_url( add_query_arg( 'p', $post_id, admin_url( 'edit-comments.php' ) ) ) . "' title='" . esc_attr( $pending_phrase ) . "' class='post-com-count'><span class='comment-count'>" . number_format_i18n( get_comments_number() ) . "</span></a>";
|
||||
$approved_only_phrase = sprintf( _n( '%s comment', '%s comments', $approved_comments ), $approved_comments_number );
|
||||
$approved_phrase = sprintf( _n( '%s approved comment', '%s approved comments', $approved_comments ), $approved_comments_number );
|
||||
$pending_phrase = sprintf( _n( '%s pending comment', '%s pending comments', $pending_comments ), $pending_comments_number );
|
||||
|
||||
if ( $pending_comments )
|
||||
echo '</strong>';
|
||||
// No comments at all.
|
||||
if ( ! $approved_comments && ! $pending_comments ) {
|
||||
printf( '<span aria-hidden="true">—</span><span class="screen-reader-text">%s</span>',
|
||||
__( 'No comments' )
|
||||
);
|
||||
// Approved comments have different display depending on some conditions.
|
||||
} elseif ( $approved_comments ) {
|
||||
printf( '<a href="%s" class="post-com-count post-com-count-approved"><span class="comment-count-approved" aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></a>',
|
||||
esc_url( add_query_arg( array( 'p' => $post_id, 'comment_status' => 'approved' ), admin_url( 'edit-comments.php' ) ) ),
|
||||
$approved_comments_number,
|
||||
$pending_comments ? $approved_phrase : $approved_only_phrase
|
||||
);
|
||||
} else {
|
||||
printf( '<span class="post-com-count post-com-count-no-comments"><span class="comment-count comment-count-no-comments" aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></span>',
|
||||
$approved_comments_number,
|
||||
$pending_comments ? __( 'No approved comments' ) : __( 'No comments' )
|
||||
);
|
||||
}
|
||||
|
||||
if ( $pending_comments ) {
|
||||
printf( '<a href="%s" class="post-com-count post-com-count-pending"><span class="comment-count-pending" aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></a>',
|
||||
esc_url( add_query_arg( array( 'p' => $post_id, 'comment_status' => 'moderated' ), admin_url( 'edit-comments.php' ) ) ),
|
||||
$pending_comments_number,
|
||||
$pending_phrase
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
|||
Loading…
Reference in New Issue