Taxonomy: Disallow overriding the `name` property when registering a taxonomy.

Props wpfo for initial patch.
Fixes #39308.

git-svn-id: https://develop.svn.wordpress.org/trunk@40049 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Pascal Birchler 2017-02-06 19:38:36 +00:00
parent 8900e2466e
commit 4004400047
2 changed files with 13 additions and 0 deletions

View File

@ -333,6 +333,8 @@ final class WP_Taxonomy {
}
}
$args['name'] = $this->name;
foreach ( $args as $property_name => $property_value ) {
$this->$property_name = $property_value;
}

View File

@ -710,4 +710,15 @@ class Tests_Taxonomy extends WP_UnitTestCase {
$this->assertFalse( taxonomy_exists( 'foo' ) );
}
/**
* @ticket 39308
*/
public function test_taxonomy_name_property_should_not_get_overridden_by_passed_args() {
register_taxonomy( 'foo', 'post', array( 'name' => 'bar' ) );
$taxonomy = get_taxonomy( 'foo' );
unregister_taxonomy( 'foo' );
$this->assertSame( 'foo', $taxonomy->name );
}
}