sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Accessibility: Add a default title for the media modal dialog.

Browse Source 
Makes sure the media modal dialog `h1` heading isn't empty when custom media frames don't set a title. This is particularly important now that the media modal is an ARIA dialog, as the title is referenced by an `aria-labelledby` attribute to properly label the dialog.

Props donmhico, audrasjb.
Fixes #47612.


git-svn-id: https://develop.svn.wordpress.org/trunk@45925 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Andrea Fercia 2019-09-01 15:17:37 +00:00
parent e2b68a4253
commit 425d6fd925
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/js/media/views/media-frame.js
View File

@ -1,4 +1,5 @@
var Frame = wp.media.view.Frame, var Frame = wp.media.view.Frame,
l10n = wp.media.view.l10n,
$ = jQuery, $ = jQuery,
MediaFrame; MediaFrame;
@ -32,7 +33,7 @@ MediaFrame = Frame.extend(/** @lends wp.media.view.MediaFrame.prototype */{
Frame.prototype.initialize.apply( this, arguments ); Frame.prototype.initialize.apply( this, arguments );
_.defaults( this.options, { _.defaults( this.options, {
title: '', title: l10n.mediaFrameDefaultTitle,
modal: true, modal: true,
uploader: true uploader: true
}); });

1
src/wp-includes/media.php
View File

@ -3764,6 +3764,7 @@ function wp_enqueue_media( $args = array() ) {
$strings = array( $strings = array(
// Generic // Generic
'mediaFrameDefaultTitle' => __( 'Media' ),
'url' => __( 'URL' ), 'url' => __( 'URL' ),
'addMedia' => __( 'Add Media' ), 'addMedia' => __( 'Add Media' ),
'search' => __( 'Search' ), 'search' => __( 'Search' ),