sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Accessibility: Media: Make the toolbar and inline uploader visual order always match the DOM order.

Browse Source 
Depending on the specific media view, the media UI elements are placed in a
different visual order. This change makes sure their visual order always
matches the DOM order.

Propos syhc, audrasjb, afercia.
See #37188.
Fixes #48403.


git-svn-id: https://develop.svn.wordpress.org/trunk@47217 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Andrea Fercia 2020-02-09 16:30:41 +00:00
parent 734bf726d7
commit 43fb40739d
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/js/media/views/attachments/browser.js
View File

@ -49,17 +49,25 @@ AttachmentsBrowser = View.extend(/** @lends wp.media.view.AttachmentsBrowser.pro
} }
/* /*
* For accessibility reasons, place the Inline Uploader before other sections. * In the grid mode (the Media Library), place the Inline Uploader before
* This way, in the Media Library, it's right after the Add New button, see ticket #37188. * other sections so that the visual order and the DOM order match. This way,
* the Inline Uploader in the Media Library is right after the "Add New"
* button, see ticket #37188.
*/ */
this.createUploader(); if ( this.controller.isModeActive( 'grid' ) ) {
this.createUploader();
/*
* Create a multi-purpose toolbar. Used as main toolbar in the Media Library
* and also for other things, for example the "Drag and drop to reorder" and
* "Suggested dimensions" info in the media modal.
*/
this.createToolbar();
} else {
this.createToolbar();
this.createUploader();
}
/*
* Create a multi-purpose toolbar. Used as main toolbar in the Media Library
* and also for other things, for example the "Drag and drop to reorder" and
* "Suggested dimensions" info in the media modal.
*/
this.createToolbar();
// Add a heading before the attachments list. // Add a heading before the attachments list.
this.createAttachmentsHeading(); this.createAttachmentsHeading();