sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Role/capability: Add more complete capability and role assertions to existing user capability tests. Also reuses one more user account fixtures.

Browse Source 
Fixes #38236
See #38235


git-svn-id: https://develop.svn.wordpress.org/trunk@38732 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
John Blackbourn 2016-10-05 17:17:02 +00:00
parent 7581f3cc25
commit 48e2bde86b
1 changed files with 33 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
tests/phpunit/tests/user/capabilities.php
View File

@ -683,10 +683,12 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$this->assertTrue($user->has_cap('sweep_floor')); $this->assertTrue($user->has_cap('sweep_floor'));
// shouldn't have any other caps // shouldn't have any other caps
$this->assertFalse($user->has_cap('upload_files')); $caps = $this->getAllCapsAndRoles();
$this->assertFalse($user->has_cap('edit_published_posts')); foreach ( $caps as $cap => $roles ) {
$this->assertFalse($user->has_cap('upload_files')); if ( 'level_1' !== $cap ) {
$this->assertFalse($user->has_cap('level_4')); $this->assertFalse( $user->has_cap( $cap ), "User should not have the {$cap} capability" );
}
}
// clean up // clean up
remove_role($role_name); remove_role($role_name);
@ -757,13 +759,14 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$this->assertFalse($user_2->has_cap('publish_posts')); $this->assertFalse($user_2->has_cap('publish_posts'));
// make sure the other caps didn't get messed up // make sure the other caps didn't get messed up
$this->assertTrue($user_1->has_cap('edit_posts')); $caps = $this->getAllCapsAndRoles();
$this->assertTrue($user_1->has_cap('read')); foreach ( $caps as $cap => $roles ) {
$this->assertTrue($user_1->has_cap('level_1')); if ( in_array( 'contributor', $roles, true ) || 'publish_posts' === $cap ) {
$this->assertTrue($user_1->has_cap('level_0')); $this->assertTrue( $user_1->has_cap( $cap ), "User should have the {$cap} capability" );
$this->assertFalse($user_1->has_cap('upload_files')); } else {
$this->assertFalse($user_1->has_cap('edit_published_posts')); $this->assertFalse( $user_1->has_cap( $cap ), "User should not have the {$cap} capability" );
$this->assertFalse($user_1->has_cap('level_2')); }
}
} }
@ -847,11 +850,10 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$user = new WP_User($id); $user = new WP_User($id);
$this->assertTrue($user->exists(), "Problem getting user $id"); $this->assertTrue($user->exists(), "Problem getting user $id");
// capabilities for the author role should be gone // all capabilities for the user should be gone
# $this->assertFalse($user->has_cap('edit_posts')); foreach ( $this->getAllCapsAndRoles() as $cap => $roles ) {
# $this->assertFalse($user->has_cap('edit_published_posts')); $this->assertFalse( $user->has_cap( $cap ), "User should not have the {$cap} capability" );
# $this->assertFalse($user->has_cap('upload_files')); }
# $this->assertFalse($user->has_cap('level_2'));
// the extra capabilities should be gone // the extra capabilities should be gone
$this->assertFalse($user->has_cap('make_coffee')); $this->assertFalse($user->has_cap('make_coffee'));
@ -959,12 +961,14 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$editor = self::$users['editor']; $editor = self::$users['editor'];
$contributor = self::$users['contributor']; $contributor = self::$users['contributor'];
// editor can edit, view, and trash // editor can publish, edit, view, and trash
$this->assertTrue( $editor->has_cap( 'publish_post', $post ) );
$this->assertTrue( $editor->has_cap( 'edit_post', $post ) ); $this->assertTrue( $editor->has_cap( 'edit_post', $post ) );
$this->assertTrue( $editor->has_cap( 'delete_post', $post ) ); $this->assertTrue( $editor->has_cap( 'delete_post', $post ) );
$this->assertTrue( $editor->has_cap( 'read_post', $post ) ); $this->assertTrue( $editor->has_cap( 'read_post', $post ) );
// a contributor cannot (except read a published post) // a contributor cannot (except read a published post)
$this->assertFalse( $contributor->has_cap( 'publish_post', $post ) );
$this->assertFalse( $contributor->has_cap( 'edit_post', $post ) ); $this->assertFalse( $contributor->has_cap( 'edit_post', $post ) );
$this->assertFalse( $contributor->has_cap( 'delete_post', $post ) ); $this->assertFalse( $contributor->has_cap( 'delete_post', $post ) );
$this->assertEquals( $status === 'publish', $contributor->has_cap( 'read_post', $post ) ); $this->assertEquals( $status === 'publish', $contributor->has_cap( 'read_post', $post ) );
@ -978,12 +982,14 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$author = self::$users['author']; $author = self::$users['author'];
$editor = self::$users['editor']; $editor = self::$users['editor'];
$contributor = self::$users['contributor']; $contributor = self::$users['contributor'];
$subscriber = self::$users['subscriber'];
// create_posts isn't a real cap. // create_posts isn't a real cap.
$this->assertFalse($admin->has_cap('create_posts')); $this->assertFalse($admin->has_cap('create_posts'));
$this->assertFalse($author->has_cap('create_posts')); $this->assertFalse($author->has_cap('create_posts'));
$this->assertFalse($editor->has_cap('create_posts')); $this->assertFalse($editor->has_cap('create_posts'));
$this->assertFalse($contributor->has_cap('create_posts')); $this->assertFalse($contributor->has_cap('create_posts'));
$this->assertFalse($subscriber->has_cap('create_posts'));
register_post_type( 'foobar' ); register_post_type( 'foobar' );
$cap = get_post_type_object( 'foobar' )->cap; $cap = get_post_type_object( 'foobar' )->cap;
@ -994,6 +1000,7 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$this->assertTrue($author->has_cap( $cap->create_posts )); $this->assertTrue($author->has_cap( $cap->create_posts ));
$this->assertTrue($editor->has_cap( $cap->create_posts )); $this->assertTrue($editor->has_cap( $cap->create_posts ));
$this->assertTrue($contributor->has_cap( $cap->create_posts )); $this->assertTrue($contributor->has_cap( $cap->create_posts ));
$this->assertFalse($subscriber->has_cap( $cap->create_posts ));
_unregister_post_type( 'foobar' ); _unregister_post_type( 'foobar' );
@ -1007,6 +1014,7 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$this->assertFalse($author->has_cap( $cap->create_posts )); $this->assertFalse($author->has_cap( $cap->create_posts ));
$this->assertFalse($editor->has_cap( $cap->create_posts )); $this->assertFalse($editor->has_cap( $cap->create_posts ));
$this->assertFalse($contributor->has_cap( $cap->create_posts )); $this->assertFalse($contributor->has_cap( $cap->create_posts ));
$this->assertFalse($subscriber->has_cap( $cap->create_posts ));
// Add edit_foobars primitive cap to a user. // Add edit_foobars primitive cap to a user.
$admin->add_cap( 'edit_foobars', true ); $admin->add_cap( 'edit_foobars', true );
@ -1015,6 +1023,7 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$this->assertFalse($author->has_cap( $cap->create_posts )); $this->assertFalse($author->has_cap( $cap->create_posts ));
$this->assertFalse($editor->has_cap( $cap->create_posts )); $this->assertFalse($editor->has_cap( $cap->create_posts ));
$this->assertFalse($contributor->has_cap( $cap->create_posts )); $this->assertFalse($contributor->has_cap( $cap->create_posts ));
$this->assertFalse($subscriber->has_cap( $cap->create_posts ));
$admin->remove_cap( 'edit_foobars' ); $admin->remove_cap( 'edit_foobars' );
@ -1028,6 +1037,7 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$this->assertTrue( $author->has_cap( $cap->edit_posts ) ); $this->assertTrue( $author->has_cap( $cap->edit_posts ) );
$this->assertTrue( $contributor->has_cap( $cap->edit_posts ) ); $this->assertTrue( $contributor->has_cap( $cap->edit_posts ) );
$this->assertFalse( $contributor->has_cap( $cap->create_posts ) ); $this->assertFalse( $contributor->has_cap( $cap->create_posts ) );
$this->assertFalse( $subscriber->has_cap( $cap->create_posts ) );
} }
function test_page_meta_caps() { function test_page_meta_caps() {
@ -1196,10 +1206,14 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
*/ */
function test_negative_caps() { function test_negative_caps() {
$author = self::$users['author']; $author = self::$users['author'];
$author->add_cap( 'foo', false ); $author->add_cap( 'foo', false );
$this->assertTrue ( isset( $author->caps['foo'] ) ); $this->assertTrue ( isset( $author->caps['foo'] ) );
$this->assertFalse( user_can( $author->ID, 'foo' ) );
$author->remove_cap( 'foo' ); $author->remove_cap( 'foo' );
$this->assertFalse ( isset( $author->caps['foo'] ) ); $this->assertFalse ( isset( $author->caps['foo'] ) );
$this->assertFalse( user_can( $author->ID, 'foo' ) );
} }
/** /**
@ -1363,7 +1377,7 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$user = new WP_User( self::factory()->user->create( array( 'role' => 'administrator' ) ) ); $user = new WP_User( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
$user->add_cap( 'manage_network_users' ); $user->add_cap( 'manage_network_users' );
$other_user = new WP_User( self::factory()->user->create( array( 'role' => 'subscriber' ) ) ); $other_user = self::$users['subscriber'];
wp_set_current_user( $user->ID ); wp_set_current_user( $user->ID );
@ -1465,6 +1479,7 @@ class Tests_User_Capabilities extends WP_UnitTestCase {
$this->assertFalse( current_user_can( $cap ), "Non-logged-in user should not have the {$cap} capability" ); $this->assertFalse( current_user_can( $cap ), "Non-logged-in user should not have the {$cap} capability" );
} }
$this->assertFalse( current_user_can( 'do_not_allow' ), "Non-logged-in user should not have the do_not_allow capability" );
} }
} }