sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Themes: Switch back from throttling to debouncing in theme searches on admin screen.

Browse Source 
Start debouncing after initial search performed when `search` query param is present to prevent initial "flash of unsearched themes".

Props afercia, westonruter.
Amends [41797].
See #40254.
Fixes #42348.


git-svn-id: https://develop.svn.wordpress.org/trunk@42029 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Weston Ruter 2017-10-27 03:30:27 +00:00
parent afa1b06984
commit 49ec33ae71
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/wp-admin/js/theme.js
View File

@ -102,6 +102,7 @@ themes.view.Appearance = wp.Backbone.View.extend({
collection: self.collection, collection: self.collection,
parent: this parent: this
}); });
self.searchView = view;
// Render and append after screen title // Render and append after screen title
view.render(); view.render();
@ -1347,12 +1348,12 @@ themes.view.Search = wp.Backbone.View.extend({
event.target.value = ''; event.target.value = '';
} }
// Note that doSearch is throttled. // Since doSearch is debounced, it will only run when user input comes to a rest.
this.doSearch( event ); this.doSearch( event );
}, },
// Runs a search on the theme collection. // Runs a search on the theme collection.
doSearch: _.throttle( function( event ) { doSearch: function( event ) {
var options = {}; var options = {};
this.collection.doSearch( event.target.value.replace( /\+/g, ' ' ) ); this.collection.doSearch( event.target.value.replace( /\+/g, ' ' ) );
@ -1370,7 +1371,7 @@ themes.view.Search = wp.Backbone.View.extend({
} else { } else {
themes.router.navigate( themes.router.baseUrl( '' ) ); themes.router.navigate( themes.router.baseUrl( '' ) );
} }
}, 500 ), },
pushState: function( event ) { pushState: function( event ) {
var url = themes.router.baseUrl( '' ); var url = themes.router.baseUrl( '' );
@ -1445,6 +1446,9 @@ themes.Run = {
}); });
this.render(); this.render();
// Start debouncing user searches after Backbone.history.start().
this.view.searchView.doSearch = _.debounce( this.view.searchView.doSearch, 500 );
}, },
render: function() { render: function() {
@ -1520,7 +1524,7 @@ themes.view.InstallerSearch = themes.view.Search.extend({
this.doSearch( event.target.value ); this.doSearch( event.target.value );
}, },
doSearch: _.throttle( function( value ) { doSearch: function( value ) {
var request = {}; var request = {};
// Don't do anything if the search terms haven't changed. // Don't do anything if the search terms haven't changed.
@ -1564,7 +1568,7 @@ themes.view.InstallerSearch = themes.view.Search.extend({
// Set route // Set route
themes.router.navigate( themes.router.baseUrl( themes.router.searchPath + encodeURIComponent( value ) ), { replace: true } ); themes.router.navigate( themes.router.baseUrl( themes.router.searchPath + encodeURIComponent( value ) ), { replace: true } );
}, 500 ) }
}); });
themes.view.Installer = themes.view.Appearance.extend({ themes.view.Installer = themes.view.Appearance.extend({
@ -1919,6 +1923,8 @@ themes.RunInstaller = {
// Render results // Render results
this.render(); this.render();
// Start debouncing user searches after Backbone.history.start().
this.view.searchView.doSearch = _.debounce( this.view.searchView.doSearch, 500 );
}, },
render: function() { render: function() {