sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Check it if matches before serializing, because get_option de-serializes. Hat tip: Donncha. 

git-svn-id: https://develop.svn.wordpress.org/trunk@2715 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Matt Mullenweg 2005-07-16 21:13:14 +00:00
parent 9527e184fe
commit 4d6ecc4943
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
wp-includes/functions.php
View File

@ -327,21 +327,22 @@ function get_alloptions() {
function update_option($option_name, $newvalue) { function update_option($option_name, $newvalue) {
global $wpdb, $cache_settings; global $wpdb, $cache_settings;
if ( is_array($newvalue) || is_object($newvalue) )
$newvalue = serialize($newvalue);
$newvalue = trim($newvalue); // I can't think of any situation we wouldn't want to trim $newvalue = trim($newvalue); // I can't think of any situation we wouldn't want to trim
// If the new and old values are the same, no need to update. // If the new and old values are the same, no need to update.
if ($newvalue == get_option($option_name)) { if ( $newvalue == get_option($option_name) )
return true; return true;
}
if ( is_array($newvalue) || is_object($newvalue) )
$newvalue = serialize($newvalue);
// If it's not there add it // If it's not there add it
if ( !$wpdb->get_var("SELECT option_name FROM $wpdb->options WHERE option_name = '$option_name'") ) if ( !$wpdb->get_var("SELECT option_name FROM $wpdb->options WHERE option_name = '$option_name'") )
add_option($option_name); add_option($option_name);
$newvalue = $wpdb->escape($newvalue); $newvalue = $wpdb->escape($newvalue);
$option_name = $wpdb->escape( $option_name );
$wpdb->query("UPDATE $wpdb->options SET option_value = '$newvalue' WHERE option_name = '$option_name'"); $wpdb->query("UPDATE $wpdb->options SET option_value = '$newvalue' WHERE option_name = '$option_name'");
$cache_settings = get_alloptions(); // Re cache settings $cache_settings = get_alloptions(); // Re cache settings
return true; return true;